feat: bump databricks-sdk v0.1.7 and rename RefreshableCredentials to SessionCredentials#349
Merged
susodapop merged 3 commits intodatabricks:staging-349from May 18, 2023
Merged
Conversation
pavs23
changed the title
3 tasks
susodapop
suggested changes
May 18, 2023
There was a problem hiding this comment.
You need to change the databricks-sdk dependency spec in setup.py, else this won't affect the dependency map that pip builds during installation.
I had to incorporate these same changes into #338 so you can see exactly where the changes are needed.
Happy to merge your PR instead and rebase my change on yours though 🚀
Contributor
Author
|
Hey @susodapop , thanks for the feedback. |
susodapop
approved these changes
May 18, 2023
susodapop
left a comment
susodapop
left a comment
There was a problem hiding this comment.
Thanks! Per the CONTRIBUTING guide, I've updated this PR to hit a staging branch so we can run our e2e tests before merging to main.
Contributor
Author
|
Thanks @susodapop :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves this issue I raised recently #348
Root cause is due to the renaming done in this PR: databricks/databricks-sdk-py#116
These types of breaking changes are normal and part of life. Would like to see this get pushed through ASAP though.
Description
databricks-sdkto use the latest version.RefreshableCredentialsreferences toSessionCredentialsIt would be failing for anyone trying to connect to databricks using
dbt-coreand thedbt-databricksadapter if I'm not mistaken.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.