Skip to content

Explicitly clear terminal environment variables before injecting new ones#996

Merged
kartikgupta-db merged 1 commit intomainfrom
explicitly-clear-terminal-env
Jan 10, 2024
Merged

Explicitly clear terminal environment variables before injecting new ones#996
kartikgupta-db merged 1 commit intomainfrom
explicitly-clear-terminal-env

Conversation

@kartikgupta-db
Copy link
Copy Markdown
Contributor

Changes

  • Environment variables are not getting refreshed by just issuing the environmentVariableCollection.replace command. We now explicitly clear the terminal env (environmentVariableCollection.clear) before injecting new variables.
  • Also synchronised writing env file and exporting to terminal. Env file is written first and we export to terminal only on successful writes.

fixes #980

Tests

  • manual

@kartikgupta-db kartikgupta-db enabled auto-merge (squash) January 10, 2024 11:19
@kartikgupta-db kartikgupta-db merged commit 2491287 into main Jan 10, 2024
This was referenced Jan 10, 2024
ilia-db added a commit that referenced this pull request Jan 10, 2024
## packages/databricks-vscode
## <small>1.2.5 (2024-01-10)</small>

* Explicitly clear terminal environment variables before injecting new
ones (#996)
([2491287](2491287)),
closes
[#996](#996)
* Permissions warning (#983)
([00c2834](00c2834)),
closes
[#983](#983)
* Rollback telemetry package (#989)
([c0abaf7](c0abaf7)),
closes
[#989](#989)
* Store `lastInstalledExtensionVersion` in the global storage so we only
show `what's new` once (#971)
([0b19816](0b19816)),
closes
[#971](#971)
* Update all the licenses (#981)
([66cf3c3](66cf3c3)),
closes
[#981](#981)
* Update Databricks CLI to v0.210.2 (#967)
([f309b5e](f309b5e)),
closes
[#967](#967)
* Update Databricks CLI to v0.210.3 (#973)
([bc340cf](bc340cf)),
closes
[#973](#973)
* Update Databricks CLI to v0.211.0 (#982)
([25d0ef2](25d0ef2)),
closes
[#982](#982)
* Update metadata url before emitting connection change events (#992)
([0cd590e](0cd590e)),
closes
[#992](#992)
* Update vscode test package (#984)
([bad500f](bad500f)),
closes
[#984](#984)



## packages/databricks-vscode-types
## <small>1.2.5 (2024-01-10)</small>

* Update all the licenses (#981)
([66cf3c3](66cf3c3)),
closes
[#981](#981)

---------

Co-authored-by: releasebot <[email protected]>
Co-authored-by: Ilia Babanov <[email protected]>
@kartikgupta-db kartikgupta-db deleted the explicitly-clear-terminal-env branch January 28, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants