Update metadata url before emitting connection change events#992
Merged
kartikgupta-db merged 2 commits intomainfrom Jan 9, 2024
Merged
Update metadata url before emitting connection change events#992kartikgupta-db merged 2 commits intomainfrom
kartikgupta-db merged 2 commits intomainfrom
Conversation
This prevents race-condition when we can attempt to save environments variables to a file and terminals before the metadata url is actually updated
kartikgupta-db
approved these changes
Jan 9, 2024
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
added a commit
that referenced
this pull request
Jan 10, 2024
## packages/databricks-vscode ## <small>1.2.5 (2024-01-10)</small> * Explicitly clear terminal environment variables before injecting new ones (#996) ([2491287](2491287)), closes [#996](#996) * Permissions warning (#983) ([00c2834](00c2834)), closes [#983](#983) * Rollback telemetry package (#989) ([c0abaf7](c0abaf7)), closes [#989](#989) * Store `lastInstalledExtensionVersion` in the global storage so we only show `what's new` once (#971) ([0b19816](0b19816)), closes [#971](#971) * Update all the licenses (#981) ([66cf3c3](66cf3c3)), closes [#981](#981) * Update Databricks CLI to v0.210.2 (#967) ([f309b5e](f309b5e)), closes [#967](#967) * Update Databricks CLI to v0.210.3 (#973) ([bc340cf](bc340cf)), closes [#973](#973) * Update Databricks CLI to v0.211.0 (#982) ([25d0ef2](25d0ef2)), closes [#982](#982) * Update metadata url before emitting connection change events (#992) ([0cd590e](0cd590e)), closes [#992](#992) * Update vscode test package (#984) ([bad500f](bad500f)), closes [#984](#984) ## packages/databricks-vscode-types ## <small>1.2.5 (2024-01-10)</small> * Update all the licenses (#981) ([66cf3c3](66cf3c3)), closes [#981](#981) --------- Co-authored-by: releasebot <[email protected]> Co-authored-by: Ilia Babanov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This prevents race-condition when we attempt to save environments variables to a file and terminals before the metadata url is actually updated.
Should help with avoiding problems like this: #980
Tests
Manually and existing unit tests