Skip to content

All AuthProviders must implement a non silent check.#936

Merged
kartikgupta-db merged 7 commits intomainfrom
mandatory-check-auth
Nov 11, 2023
Merged

All AuthProviders must implement a non silent check.#936
kartikgupta-db merged 7 commits intomainfrom
mandatory-check-auth

Conversation

@kartikgupta-db
Copy link
Copy Markdown
Contributor

Changes

  • Moving forward, we want to avoid having silent checks to make reasoning about auth easier. This PR makes it so that all AuthProviders must implement the check method.
  • Each check method must handle it's own Retry Loop, error handling and display. Since now checks are always interactive, we do not want calling code to manage the interactions.

Tests

  • manual

kartikgupta-db and others added 6 commits October 27, 2023 15:55
## Changes
* Autogenerate BundleSchema.d.ts file (from `databricks bundle schema`
command) to provide typing for the parsed bundle object.
* Add a watcher for all DABs configuration files
* Add BundleFileSet object, to handle operations on the full bundle file
tree.
* Used these to add autocompletion for all files included in the root
bundle.yaml.

**NOTE:** This PR currently parses yamls in code. We want to move that
to databricks CLI. The implementation can is modular and can be swapped
with the CLI calls once we have those features in the CLI.

## Tests
* Unit tests
* Manual
## Changes
* Fixes a big in
#892, which caused
the bundle autocomplete to not recognise a new file.
* Bundle autocomplete now updates monitored files when
  * there is a change to the bundle root
  * a bundle file is created
  * a bundle file is deleted


## Tests
* manual
## Changes
* Adds
* `BundleConfigReaderWriter`: Manages reading and writing configs
to/from the `BundleFileSet`
* `ConfigOverrideReaderWriter`: Manages reading and writing configs
to/from the `StateStorage`
* `ConfigModel`: Provides a centralised view of the configs after
applying any overrides. This is the single source of truth for all
features that require reading/writing these configs.


## Tests
<!-- How is this tested? -->
…is deleted (#931)

## Changes
Fixes
#922 (comment)
## Tests
<!-- How is this tested? -->
@kartikgupta-db kartikgupta-db merged commit 237e629 into main Nov 11, 2023
@kartikgupta-db kartikgupta-db deleted the mandatory-check-auth branch November 11, 2023 13:21
kartikgupta-db added a commit that referenced this pull request Nov 11, 2023
@kartikgupta-db kartikgupta-db restored the mandatory-check-auth branch November 11, 2023 13:23
@kartikgupta-db kartikgupta-db deleted the mandatory-check-auth branch November 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant