All AuthProviders must implement a non silent check.#936
Merged
kartikgupta-db merged 7 commits intomainfrom Nov 11, 2023
Merged
All AuthProviders must implement a non silent check.#936kartikgupta-db merged 7 commits intomainfrom
AuthProviders must implement a non silent check.#936kartikgupta-db merged 7 commits intomainfrom
Conversation
## Changes * Autogenerate BundleSchema.d.ts file (from `databricks bundle schema` command) to provide typing for the parsed bundle object. * Add a watcher for all DABs configuration files * Add BundleFileSet object, to handle operations on the full bundle file tree. * Used these to add autocompletion for all files included in the root bundle.yaml. **NOTE:** This PR currently parses yamls in code. We want to move that to databricks CLI. The implementation can is modular and can be swapped with the CLI calls once we have those features in the CLI. ## Tests * Unit tests * Manual
## Changes * Fixes a big in #892, which caused the bundle autocomplete to not recognise a new file. * Bundle autocomplete now updates monitored files when * there is a change to the bundle root * a bundle file is created * a bundle file is deleted ## Tests * manual
## Changes * Adds * `BundleConfigReaderWriter`: Manages reading and writing configs to/from the `BundleFileSet` * `ConfigOverrideReaderWriter`: Manages reading and writing configs to/from the `StateStorage` * `ConfigModel`: Provides a centralised view of the configs after applying any overrides. This is the single source of truth for all features that require reading/writing these configs. ## Tests <!-- How is this tested? -->
…is deleted (#931) ## Changes Fixes #922 (comment) ## Tests <!-- How is this tested? -->
kartikgupta-db
added a commit
that referenced
this pull request
Nov 11, 2023
This reverts commit 237e629.
kartikgupta-db
added a commit
that referenced
this pull request
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
checkmethod.Tests