Conversation
fjakobs
commented
May 19, 2023
| | "azure-cli" | ||
| | "google-id" | ||
| | "metadata-service" | ||
| | "bricks-cli"; |
Contributor
Author
Contributor
There was a problem hiding this comment.
Not done yet, should be databricks-cli, and we check for os.Stat of the binary to be >= 1 meg.
Contributor
There was a problem hiding this comment.
Can you revert just the auth type name? Then we unblock merging this and we do it in a patch bump.
pietern
approved these changes
May 19, 2023
| | "azure-cli" | ||
| | "google-id" | ||
| | "metadata-service" | ||
| | "bricks-cli"; |
Contributor
There was a problem hiding this comment.
Not done yet, should be databricks-cli, and we check for os.Stat of the binary to be >= 1 meg.
packages/databricks-sdk-js/src/config/DatabricksCliCredentials.ts
Outdated
Show resolved
Hide resolved
| } catch (e) { | ||
| throw new ConfigError( | ||
| `bricks-cli: cannot unmarshal Bricks CLI result: ${e}`, | ||
| `databricks-cli: cannot unmarshal Bricks CLI result: ${e}`, |
Contributor
There was a problem hiding this comment.
Still remaining in message.
fjakobs
added a commit
to databricks/cli
that referenced
this pull request
May 22, 2023
## Changes related to databricks/databricks-vscode#721 ## Rename env vars `BRICKS_CLI_PATH` -> `DATABRICKS_CLI_PATH` `BRICKS_OUTPUT_FORMAT` -> `DATABRICKS_OUTPUT_FORMAT` `BRICKS_LOG_FILE` -> `DATABRICKS_LOG_FILE` `BRICKS_LOG_LEVEL` -> `DATABRICKS_LOG_LEVEL` `BRICKS_LOG_FORMAT` -> `DATABRICKS_LOG_FORMAT` `BRICKS_PROGRESS_FORMAT` -> `DATABRICKS_CLI_PROGRESS_FORMAT` `BRICKS_UPSTREAM` -> `DATABRICKS_CLI_UPSTREAM` `BRICKS_UPSTREAM_VERSION` -> `DATABRICKS_CLI_UPSTREAM_VERSION`
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 82.47% 81.90% -0.57%
==========================================
Files 40 40
Lines 1478 1487 +9
Branches 290 294 +4
==========================================
- Hits 1219 1218 -1
- Misses 259 269 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Rename CLI from
brickstodatabricksTesting