Skip to content

Use "bundle sync" instead of "bundle deploy" for remote run commands#1401

Merged
ilia-db merged 6 commits intobundle-integfrom
ilia-db/sync-before-run
Oct 24, 2024
Merged

Use "bundle sync" instead of "bundle deploy" for remote run commands#1401
ilia-db merged 6 commits intobundle-integfrom
ilia-db/sync-before-run

Conversation

@ilia-db
Copy link
Copy Markdown
Contributor

@ilia-db ilia-db commented Oct 22, 2024 •
edited
Loading

Changes

Also changes the continuous sync logic to use the bundle sync command instead of the sync.

Depends on the CLI PR: databricks/cli#1853

Sync E2E tests will be failing until we update the CLI

Tests

Manual and existing unit and e2e tests

@ilia-db
Use bundle sync instead of deploy before remote run commands
8814c7a 
Also changes Sync logic to use the bundle sync command.

Depends on the CLI PR: databricks/cli#1853
@ilia-db
Fix tests
ece4b34
@ilia-db ilia-db requested a review from fjakobs October 22, 2024 11:42
@ilia-db ilia-db changed the title Ilia db/sync before run Use "bundle sync" instead of "bundle deploy" for remote run commands Oct 22, 2024
@ilia-db ilia-db mentioned this pull request Oct 22, 2024
Merged
@ilia-db
Move tests around
bd269f6 
Cancelling test is flaky. Having it on the first place will make sync command a bit slower, since it will
actually have to sync files, instead of being a no op
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Oct 24, 2024

Test status: failure
Commit SHA: c6ab10d

@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjakobs fjakobs fjakobs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilia-db @eng-dev-ecosystem-bot @fjakobs