Limit onError usages to high level functions (#999)

kartikgupta-db · web-flow · commit cac96048309d · 2024-01-11T16:41:05.000+01:00
## Changes
&lt;!-- Summary of your changes that are easy to understand --&gt;

## Tests
&lt;!-- How is this tested? --&gt;
diff --git a/packages/databricks-vscode/src/bundle/models/BundleValidateModel.ts b/packages/databricks-vscode/src/bundle/models/BundleValidateModel.ts
@@ -52,7 +52,6 @@ export class BundleValidateModel extends BaseModelWithStateCache<BundleValidateS
         }
     }
 
-    @onError({popup: {prefix: "Failed to parse bundle validate ouput"}})
     protected async readState(): Promise<BundleValidateState> {
         if (this.target === undefined || this.authProvider === undefined) {
             return {};
diff --git a/packages/databricks-vscode/src/configuration/models/ConfigModel.ts b/packages/databricks-vscode/src/configuration/models/ConfigModel.ts
@@ -177,7 +177,6 @@ export class ConfigModel implements Disposable {
     /**
      * Set target in the state storage and invalidate the configs cache.
      */
-    @onError({popup: {prefix: "Failed to set target."}})
     public async setTarget(target: string | undefined) {
         if (target === this._target) {
             return;
@@ -248,7 +247,6 @@ export class ConfigModel implements Disposable {
             : undefined;
     }
 
-    @onError({popup: {prefix: "Failed to set config."}})
     @Mutex.synchronise("configsMutex")
     public async set<T extends keyof ConfigState>(
         key: T,
diff --git a/packages/databricks-vscode/src/configuration/models/OverrideableConfigModel.ts b/packages/databricks-vscode/src/configuration/models/OverrideableConfigModel.ts
@@ -33,7 +33,6 @@ export class OverrideableConfigModel extends BaseModelWithStateCache<Overrideabl
         await this.stateCache.refresh();
     }
 
-    @onError({popup: {prefix: "Error while reading config overrides"}})
     protected async readState() {
         if (this.target === undefined) {
             return {};

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ export class BundleValidateModel extends BaseModelWithStateCache<BundleValidateS`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`- @onError({popup: {prefix: "Failed to parse bundle validate ouput"}})`
`56`	`55`	`protected async readState(): Promise<BundleValidateState> {`
`57`	`56`	`if (this.target === undefined \|\| this.authProvider === undefined) {`
`58`	`57`	`return {};`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ export class OverrideableConfigModel extends BaseModelWithStateCache<Overrideabl`
`33`	`33`	`await this.stateCache.refresh();`
`34`	`34`	`}`
`35`	`35`
`36`		`- @onError({popup: {prefix: "Error while reading config overrides"}})`
`37`	`36`	`protected async readState() {`
`38`	`37`	`if (this.target === undefined) {`
`39`	`38`	`return {};`