Skip to content

[Internal] revert Support Models in dbutils.fs operations (#750)#778

Merged
mgyucht merged 1 commit intodatabricks:mainfrom
shichengzhou-db:revert_pr_750
Oct 7, 2024
Merged

[Internal] revert Support Models in dbutils.fs operations (#750)#778
mgyucht merged 1 commit intodatabricks:mainfrom
shichengzhou-db:revert_pr_750

Conversation

@shichengzhou-db
Copy link
Copy Markdown
Contributor

@shichengzhou-db shichengzhou-db commented Oct 3, 2024

This reverts commit 3162545.
Verified that /Models download still work correctly.

Changes

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@shichengzhou-db shichengzhou-db changed the title Revert "[Feature] Support Models in dbutils.fs operations (#750)" [Revert "Feature] "[Feature] Support Models in dbutils.fs operations (#750)" Oct 3, 2024
@shichengzhou-db shichengzhou-db changed the title [Revert "Feature] "[Feature] Support Models in dbutils.fs operations (#750)" [Internal] revert Support Models in dbutils.fs operations (#750) Oct 3, 2024
@szhou42
Copy link
Copy Markdown

szhou42 commented Oct 4, 2024

hey @mgyucht ,still need your stamp to land the pr, lmk if you have questions

@shichengzhou-db
Copy link
Copy Markdown
Contributor Author

hey @mgyucht ,still need your stamp to land the pr, lmk if you have questions

oh snap, accidentally opened this page on my personal github..

@mgyucht mgyucht added this pull request to the merge queue Oct 7, 2024
Merged via the queue into databricks:main with commit a1df7a7 Oct 7, 2024
parthban-db added a commit that referenced this pull request Oct 7, 2024
### Bug Fixes

 * Fix Model Serving Test ([#781](#781)).
 * Include package name for external types when deserializing responses ([#786](#786)).

### Internal Changes

 * Refactor ApiClient into `_BaseClient` and `ApiClient` ([#785](#785)).
 * Update to latest OpenAPI spec ([#787](#787)).
 * revert Support Models in `dbutils.fs` operations ([#750](#750)) ([#778](#778)).

### API Changes:

 * Added [w.disable_legacy_dbfs](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/disable_legacy_dbfs.html) workspace-level service.
 * Added `default_source_code_path` and `resources` fields for `databricks.sdk.service.apps.App`.
 * Added `resources` field for `databricks.sdk.service.apps.CreateAppRequest`.
 * Added `resources` field for `databricks.sdk.service.apps.UpdateAppRequest`.

OpenAPI SHA: bc17b474818138f19b78a7bea0675707dead2b87, Date: 2024-10-07
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
### Bug Fixes

* Fix Model Serving Test
([#781](#781)).
* Include package name for external types when deserializing responses
([#786](#786)).


### Internal Changes

* Refactor ApiClient into `_BaseClient` and `ApiClient`
([#785](#785)).
* Update to latest OpenAPI spec
([#787](#787)).
* revert Support Models in `dbutils.fs` operations
([#750](#750))
([#778](#778)).


### API Changes:

* Added
[w.disable_legacy_dbfs](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/disable_legacy_dbfs.html)
workspace-level service.
* Added `default_source_code_path` and `resources` fields for
`databricks.sdk.service.apps.App`.
* Added `resources` field for
`databricks.sdk.service.apps.CreateAppRequest`.
* Added `resources` field for
`databricks.sdk.service.apps.UpdateAppRequest`.

OpenAPI SHA: bc17b474818138f19b78a7bea0675707dead2b87, Date: 2024-10-07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants