[Internal] Fix test_iam::test_scim_error_unmarshall integration test#743
Merged
[Internal] Fix test_iam::test_scim_error_unmarshall integration test#743
Conversation
tanmay-db
approved these changes
Sep 2, 2024
mgyucht
added a commit
that referenced
this pull request
Sep 4, 2024
### Bug Fixes * Handle non-JSON errors gracefully ([#741](#741)). ### Documentation * Add Data Plane access documentation ([#732](#732)). ### Internal Changes * Fix test_iam::test_scim_error_unmarshall integration test ([#743](#743)). ### API Changes: * Added `regenerate_dashboard()` method for [w.quality_monitors](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/quality_monitors.html) workspace-level service. * Added `databricks.sdk.service.catalog.RegenerateDashboardRequest` and `databricks.sdk.service.catalog.RegenerateDashboardResponse` dataclasses. * Added `databricks.sdk.service.jobs.QueueDetails`, `databricks.sdk.service.jobs.QueueDetailsCodeCode`, `databricks.sdk.service.jobs.RunLifecycleStateV2State`, `databricks.sdk.service.jobs.RunStatus`, `databricks.sdk.service.jobs.TerminationCodeCode`, `databricks.sdk.service.jobs.TerminationDetails` and `databricks.sdk.service.jobs.TerminationTypeType` dataclasses. * Added `status` field for `databricks.sdk.service.jobs.BaseRun`. * Added `status` field for `databricks.sdk.service.jobs.RepairHistoryItem`. * Added `status` field for `databricks.sdk.service.jobs.Run`. * Added `status` field for `databricks.sdk.service.jobs.RunTask`. * Added `max_provisioned_throughput` and `min_provisioned_throughput` fields for `databricks.sdk.service.serving.ServedModelInput`. * Added `columns_to_sync` field for `databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`. * Changed `workload_size` field for `databricks.sdk.service.serving.ServedModelInput` to no longer be required. OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Bug Fixes * Handle non-JSON errors gracefully ([#741](#741)). ### Documentation * Add Data Plane access documentation ([#732](#732)). ### Internal Changes * Fix test_iam::test_scim_error_unmarshall integration test ([#743](#743)). ### API Changes: * Added `regenerate_dashboard()` method for [w.quality_monitors](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/quality_monitors.html) workspace-level service. * Added `databricks.sdk.service.catalog.RegenerateDashboardRequest` and `databricks.sdk.service.catalog.RegenerateDashboardResponse` dataclasses. * Added `databricks.sdk.service.jobs.QueueDetails`, `databricks.sdk.service.jobs.QueueDetailsCodeCode`, `databricks.sdk.service.jobs.RunLifecycleStateV2State`, `databricks.sdk.service.jobs.RunStatus`, `databricks.sdk.service.jobs.TerminationCodeCode`, `databricks.sdk.service.jobs.TerminationDetails` and `databricks.sdk.service.jobs.TerminationTypeType` dataclasses. * Added `status` field for `databricks.sdk.service.jobs.BaseRun`. * Added `status` field for `databricks.sdk.service.jobs.RepairHistoryItem`. * Added `status` field for `databricks.sdk.service.jobs.Run`. * Added `status` field for `databricks.sdk.service.jobs.RunTask`. * Added `max_provisioned_throughput` and `min_provisioned_throughput` fields for `databricks.sdk.service.serving.ServedModelInput`. * Added `columns_to_sync` field for `databricks.sdk.service.vectorsearch.DeltaSyncVectorIndexSpecRequest`. * Changed `workload_size` field for `databricks.sdk.service.serving.ServedModelInput` to no longer be required. OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The error message returned by the SCIM API when using an invalid filter changed, breaking our integration test. This PR updates the test to check for the type of error returned, which should be robust to error message changes. The new error message,
InvalidFilter request failed, is worse in my opinion, so I will raise this with the identity team.Tests
make testrun locallymake fmtapplied