Conversation
tanmay-db
approved these changes
May 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 57.89% 52.42% -5.47%
==========================================
Files 44 47 +3
Lines 27956 28667 +711
==========================================
- Hits 16185 15030 -1155
- Misses 11771 13637 +1866 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mgyucht
added a commit
that referenced
this pull request
May 3, 2024
### New Features * DBUtils implementation for Volumes ([#623](#623), [#634](#634), [#631](#631)). ### Bug Fixes * Fixed codecov for repository ([#636](#636)). API Changes: * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.CreatePipeline`. * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.EditPipeline`. * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.PipelineSpec`. * Added `databricks.sdk.service.pipelines.IngestionConfig` dataclass. * Added `databricks.sdk.service.pipelines.ManagedIngestionPipelineDefinition` dataclass. * Added `databricks.sdk.service.pipelines.SchemaSpec` dataclass. * Added `databricks.sdk.service.pipelines.TableSpec` dataclass. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service . New request type is `databricks.sdk.service.serving.CreateAppRequest` dataclass. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service to return `databricks.sdk.service.serving.App` dataclass. * Removed `delete_app()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_app()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_app_deployment_status()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_apps()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_events()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `create_deployment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `delete()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_deployment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_environment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `list()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `list_deployments()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `stop()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `update()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_open_api()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Removed `databricks.sdk.service.serving.AppEvents` dataclass. * Removed `databricks.sdk.service.serving.AppManifest` dataclass. * Removed `databricks.sdk.service.serving.AppServiceStatus` dataclass. * Removed `databricks.sdk.service.serving.DeleteAppResponse` dataclass. * Removed `databricks.sdk.service.serving.DeployAppRequest` dataclass. * Removed `databricks.sdk.service.serving.DeploymentStatus` dataclass. * Removed `databricks.sdk.service.serving.DeploymentStatusState` dataclass. * Removed `databricks.sdk.service.serving.GetAppDeploymentStatusRequest` dataclass. * Removed `databricks.sdk.service.serving.GetAppResponse` dataclass. * Removed `databricks.sdk.service.serving.GetEventsRequest` dataclass. * Removed `databricks.sdk.service.serving.ListAppEventsResponse` dataclass. * Changed `apps` field for `databricks.sdk.service.serving.ListAppsResponse` to `databricks.sdk.service.serving.AppList` dataclass. * Added `databricks.sdk.service.serving.App` dataclass. * Added `databricks.sdk.service.serving.AppDeployment` dataclass. * Added `databricks.sdk.service.serving.AppDeploymentState` dataclass. * Added `databricks.sdk.service.serving.AppDeploymentStatus` dataclass. * Added `databricks.sdk.service.serving.AppEnvironment` dataclass. * Added `databricks.sdk.service.serving.AppState` dataclass. * Added `databricks.sdk.service.serving.AppStatus` dataclass. * Added `databricks.sdk.service.serving.CreateAppDeploymentRequest` dataclass. * Added `databricks.sdk.service.serving.CreateAppRequest` dataclass. * Added `databricks.sdk.service.serving.EnvVariable` dataclass. * Added `databricks.sdk.service.serving.GetAppDeploymentRequest` dataclass. * Added `databricks.sdk.service.serving.GetAppEnvironmentRequest` dataclass. * Added `databricks.sdk.service.serving.GetOpenApiRequest` dataclass. * Added `any` dataclass. * Added `databricks.sdk.service.serving.ListAppDeploymentsRequest` dataclass. * Added `databricks.sdk.service.serving.ListAppDeploymentsResponse` dataclass. * Added `databricks.sdk.service.serving.ListAppsRequest` dataclass. * Added `databricks.sdk.service.serving.StopAppRequest` dataclass. * Added `any` dataclass. * Added `databricks.sdk.service.serving.UpdateAppRequest` dataclass. * Removed [w.csp_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/csp_enablement.html) workspace-level service. * Removed [w.esm_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/esm_enablement.html) workspace-level service. * Added [w.compliance_security_profile](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/compliance_security_profile.html) workspace-level service. * Added [w.enhanced_security_monitoring](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/enhanced_security_monitoring.html) workspace-level service. * Removed `databricks.sdk.service.settings.CspEnablement` dataclass. * Removed `databricks.sdk.service.settings.CspEnablementSetting` dataclass. * Removed `databricks.sdk.service.settings.EsmEnablement` dataclass. * Removed `databricks.sdk.service.settings.EsmEnablementSetting` dataclass. * Removed `databricks.sdk.service.settings.GetCspEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.GetEsmEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.UpdateCspEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.UpdateEsmEnablementSettingRequest` dataclass. * Added `databricks.sdk.service.settings.ComplianceSecurityProfile` dataclass. * Added `databricks.sdk.service.settings.ComplianceSecurityProfileSetting` dataclass. * Added `databricks.sdk.service.settings.EnhancedSecurityMonitoring` dataclass. * Added `databricks.sdk.service.settings.EnhancedSecurityMonitoringSetting` dataclass. * Added `databricks.sdk.service.settings.GetComplianceSecurityProfileSettingRequest` dataclass. * Added `databricks.sdk.service.settings.GetEnhancedSecurityMonitoringSettingRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateComplianceSecurityProfileSettingRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateEnhancedSecurityMonitoringSettingRequest` dataclass. * Added `tags` field for `databricks.sdk.service.sql.DashboardEditContent`. * Added `tags` field for `databricks.sdk.service.sql.QueryEditContent`. * Added `catalog` field for `databricks.sdk.service.sql.QueryOptions`. * Added `schema` field for `databricks.sdk.service.sql.QueryOptions`. * Added `tags` field for `databricks.sdk.service.sql.QueryPostContent`. * Added `query` field for `databricks.sdk.service.sql.Visualization`. OpenAPI SHA: 9bb7950fa3390afb97abaa552934bc0a2e069de5, Date: 2024-05-02
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 3, 2024
### New Features * DBUtils implementation for Volumes ([#623](#623), [#634](#634), [#631](#631)). You can now use `w.dbutils.fs` with UC volumes paths. Error handling for non-UC, non-DBFS and non-local paths has also been improved. ### Bug Fixes * Fixed codecov for repository ([#636](#636)). API Changes: * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.CreatePipeline`. * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.EditPipeline`. * Added `ingestion_definition` field for `databricks.sdk.service.pipelines.PipelineSpec`. * Added `databricks.sdk.service.pipelines.IngestionConfig` dataclass. * Added `databricks.sdk.service.pipelines.ManagedIngestionPipelineDefinition` dataclass. * Added `databricks.sdk.service.pipelines.SchemaSpec` dataclass. * Added `databricks.sdk.service.pipelines.TableSpec` dataclass. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service . New request type is `databricks.sdk.service.serving.CreateAppRequest` dataclass. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service to return `databricks.sdk.service.serving.App` dataclass. * Removed `delete_app()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_app()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_app_deployment_status()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_apps()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Removed `get_events()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `create_deployment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `delete()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_deployment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_environment()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `list()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `list_deployments()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `stop()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `update()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service. * Added `get_open_api()` method for [w.serving_endpoints](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/serving_endpoints.html) workspace-level service. * Removed `databricks.sdk.service.serving.AppEvents` dataclass. * Removed `databricks.sdk.service.serving.AppManifest` dataclass. * Removed `databricks.sdk.service.serving.AppServiceStatus` dataclass. * Removed `databricks.sdk.service.serving.DeleteAppResponse` dataclass. * Removed `databricks.sdk.service.serving.DeployAppRequest` dataclass. * Removed `databricks.sdk.service.serving.DeploymentStatus` dataclass. * Removed `databricks.sdk.service.serving.DeploymentStatusState` dataclass. * Removed `databricks.sdk.service.serving.GetAppDeploymentStatusRequest` dataclass. * Removed `databricks.sdk.service.serving.GetAppResponse` dataclass. * Removed `databricks.sdk.service.serving.GetEventsRequest` dataclass. * Removed `databricks.sdk.service.serving.ListAppEventsResponse` dataclass. * Changed `apps` field for `databricks.sdk.service.serving.ListAppsResponse` to `databricks.sdk.service.serving.AppList` dataclass. * Added `databricks.sdk.service.serving.App` dataclass. * Added `databricks.sdk.service.serving.AppDeployment` dataclass. * Added `databricks.sdk.service.serving.AppDeploymentState` dataclass. * Added `databricks.sdk.service.serving.AppDeploymentStatus` dataclass. * Added `databricks.sdk.service.serving.AppEnvironment` dataclass. * Added `databricks.sdk.service.serving.AppState` dataclass. * Added `databricks.sdk.service.serving.AppStatus` dataclass. * Added `databricks.sdk.service.serving.CreateAppDeploymentRequest` dataclass. * Added `databricks.sdk.service.serving.CreateAppRequest` dataclass. * Added `databricks.sdk.service.serving.EnvVariable` dataclass. * Added `databricks.sdk.service.serving.GetAppDeploymentRequest` dataclass. * Added `databricks.sdk.service.serving.GetAppEnvironmentRequest` dataclass. * Added `databricks.sdk.service.serving.GetOpenApiRequest` dataclass. * Added `any` dataclass. * Added `databricks.sdk.service.serving.ListAppDeploymentsRequest` dataclass. * Added `databricks.sdk.service.serving.ListAppDeploymentsResponse` dataclass. * Added `databricks.sdk.service.serving.ListAppsRequest` dataclass. * Added `databricks.sdk.service.serving.StopAppRequest` dataclass. * Added `any` dataclass. * Added `databricks.sdk.service.serving.UpdateAppRequest` dataclass. * Removed [w.csp_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/csp_enablement.html) workspace-level service. * Removed [w.esm_enablement](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/esm_enablement.html) workspace-level service. * Added [w.compliance_security_profile](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/compliance_security_profile.html) workspace-level service. * Added [w.enhanced_security_monitoring](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/enhanced_security_monitoring.html) workspace-level service. * Removed `databricks.sdk.service.settings.CspEnablement` dataclass. * Removed `databricks.sdk.service.settings.CspEnablementSetting` dataclass. * Removed `databricks.sdk.service.settings.EsmEnablement` dataclass. * Removed `databricks.sdk.service.settings.EsmEnablementSetting` dataclass. * Removed `databricks.sdk.service.settings.GetCspEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.GetEsmEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.UpdateCspEnablementSettingRequest` dataclass. * Removed `databricks.sdk.service.settings.UpdateEsmEnablementSettingRequest` dataclass. * Added `databricks.sdk.service.settings.ComplianceSecurityProfile` dataclass. * Added `databricks.sdk.service.settings.ComplianceSecurityProfileSetting` dataclass. * Added `databricks.sdk.service.settings.EnhancedSecurityMonitoring` dataclass. * Added `databricks.sdk.service.settings.EnhancedSecurityMonitoringSetting` dataclass. * Added `databricks.sdk.service.settings.GetComplianceSecurityProfileSettingRequest` dataclass. * Added `databricks.sdk.service.settings.GetEnhancedSecurityMonitoringSettingRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateComplianceSecurityProfileSettingRequest` dataclass. * Added `databricks.sdk.service.settings.UpdateEnhancedSecurityMonitoringSettingRequest` dataclass. * Added `tags` field for `databricks.sdk.service.sql.DashboardEditContent`. * Added `tags` field for `databricks.sdk.service.sql.QueryEditContent`. * Added `catalog` field for `databricks.sdk.service.sql.QueryOptions`. * Added `schema` field for `databricks.sdk.service.sql.QueryOptions`. * Added `tags` field for `databricks.sdk.service.sql.QueryPostContent`. * Added `query` field for `databricks.sdk.service.sql.Visualization`. OpenAPI SHA: 9bb7950fa3390afb97abaa552934bc0a2e069de5, Date: 2024-05-02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DBUtils in the SDK only supports the
dbfsandfileschemes. Within DBFS, only paths in the root filesystem are supported, not mountpoints. Other schemes are not supported. To minimize customer confusion, we can check for this case during all DBUtils FS operations when constructing the path.Tests
Added a unit test for this case.
make testrun locallymake fmtapplied