Create a deepcopy of config when creating workspace client from account client#542
Merged
kartikgupta-db merged 3 commits intomainfrom Feb 12, 2024
Merged
Create a deepcopy of config when creating workspace client from account client#542kartikgupta-db merged 3 commits intomainfrom
kartikgupta-db merged 3 commits intomainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 57.89% 57.92% +0.03%
==========================================
Files 44 45 +1
Lines 27956 27990 +34
==========================================
+ Hits 16185 16214 +29
- Misses 11771 11776 +5 ☔ View full report in Codecov by Sentry. |
edwardfeng-db
approved these changes
Feb 12, 2024
Contributor
edwardfeng-db
left a comment
edwardfeng-db
left a comment
There was a problem hiding this comment.
Thanks @kartikgupta-db
mgyucht
added a commit
that referenced
this pull request
Feb 15, 2024
This is a patch release with two small changes: * Add `get_workspace_id()` to WorkspaceClient ([#537](#537)). Bugfix: * Create a deepcopy of config when creating workspace client from account client ([#542](#542)). This fixes an issue where `AccountClient` instances would stop working after calling `get_workspace_client()`.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallymake fmtapplied