Conversation
nfx
added
enhancement
Contributor
|
Can we separate these two changes into two separate PRs? |
This PR removes `XxxRequest` classes that are referenced only as requests, effectively removing the undocumented `request=(XxxRequest(foo=1))` API. This will enforce validation on the field names for specific requests. This PR also adds validation of custom types on the request level, so that it's clear also at the runtime level when an invalid request has been supplied.
nfx
force-pushed
the
remove-request-class
branch
from
c5c0d82 to
a29affa
Compare
nfx
changed the title
**kwargs from methods and add argument validation**kwargs from methods
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 53.72% 52.66% -1.07%
==========================================
Files 33 33
Lines 19349 18197 -1152
==========================================
- Hits 10396 9583 -813
+ Misses 8953 8614 -339
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
integration tests pass 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
XxxRequestclasses that are referenced only as requests, effectively removing the undocumentedrequest=(XxxRequest(foo=1))API. This will enforce validation on the field names and make error messages more clear.