Skip to content

Correctly parse libraries in service.jobs#168

Closed
judahrand wants to merge 1 commit intodatabricks:mainfrom
judahrand:fix-libraries
Closed

Correctly parse libraries in service.jobs#168
judahrand wants to merge 1 commit intodatabricks:mainfrom
judahrand:fix-libraries

Conversation

@judahrand
Copy link
Copy Markdown
Contributor

@judahrand judahrand commented Jun 14, 2023

Changes

Pretty self explanatory. Currently, this is correct in most places but is wrong in the jobs service. I suspect there is either a bug in the service.py.tmpl or a mistake in the OpenAPI spec.

I'd debug it myself but since the OpenAPI spec is available anywhere in raw form that's a bit tricky. Could you make in available, please?

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@nfx
Copy link
Copy Markdown
Contributor

nfx commented Jun 14, 2023

this file is auto-generated and will silently be rewritten in other releases. we'll have to fix bug on generator template side

@judahrand
Copy link
Copy Markdown
Contributor Author

judahrand commented Jun 14, 2023

I'd debug it myself but since the OpenAPI spec is available anywhere in raw form that's a bit tricky. Could you make in available, please?

I'd debug it myself but since the OpenAPI spec isn't available anywhere in raw form that's a bit tricky. Could you make in available, please?

@nfx
Copy link
Copy Markdown
Contributor

nfx commented Jun 14, 2023

@judahrand it's proprietary for now :)

@nfx nfx added the codegen issues related to generated code label Jun 14, 2023
@judahrand
Copy link
Copy Markdown
Contributor Author

@judahrand it's proprietary for now :)

Well sort of... it could mostly be reverse engineered from this SDK I'd guess. Also seems like an unhelpful thing to make proprietary given that it defines how to interact with the Databricks service. Surely Databricks wants as many services as possible to integrate with Databricks?

You used to publish your JobsAPI 2.1 YAML... but that seems to have been yanked.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (8dacd83) 53.26% compared to head (55d7749) 53.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files          30       30           
  Lines       18190    18190           
=======================================
  Hits         9688     9688           
  Misses       8502     8502           
Impacted Files Coverage Δ
databricks/sdk/service/jobs.py 55.47% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nfx
Copy link
Copy Markdown
Contributor

nfx commented Jun 14, 2023

@judahrand we first want a few good official SDKs that work the same, configure the same, and feel the same and are available for every major language :) thanks for your bug reports!

@judahrand
Copy link
Copy Markdown
Contributor Author

I suspect that the issue might actually be in the OpenAPI definitions for the Jobs API since it only seems to happen for the Jobs service and not other services.

nfx added a commit that referenced this pull request Jun 15, 2023
@nfx
Copy link
Copy Markdown
Contributor

nfx commented Jun 15, 2023

Fixing with more entities in #178

@nfx nfx closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codegen issues related to generated code do-not-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants