Skip to content

use shell for opening az cli#117

Merged
nfx merged 4 commits intodatabricks:mainfrom
grusin-db:cli-fix-windows
May 17, 2023
Merged

use shell for opening az cli#117
nfx merged 4 commits intodatabricks:mainfrom
grusin-db:cli-fix-windows

Conversation

@grusin-db
Copy link
Copy Markdown
Contributor

@grusin-db grusin-db commented May 17, 2023

Changes

handle calling az login or alike cmd commands on windows 10 (and possibly other versions of windows). it seems that windows (and only windows) requires shell=True when executing sub processes.

code checks if running on windows and only uses shell execution mode.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied
  • tested additionally conditional code on windows machine, but outside of build system, just on sample copied code (build tests on windows machine are not working yet...).

@nfx nfx merged commit 113f2e5 into databricks:main May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples ([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)).
* Make ApiClient more `pyodide` friendly ([#114](#114)).
* Persist token acquired through `external-browser` auth type ([#110](#110)).
* Prototype for notebook-native auth ([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)).
* Use shell for opening `az` cli on Windows ([#117](#117)).
@nfx nfx mentioned this pull request May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples
([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount`
([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth
handshake
([#108](#108)).
* Make ApiClient more `pyodide` friendly
([#114](#114)).
* Persist token acquired through `external-browser` auth type
([#110](#110)).
* Prototype for notebook-native auth
([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials`
([#116](#116)).
* Use shell for opening `az` cli on Windows
([#117](#117)).
joyaung pushed a commit to joyaung/databricks-sdk-py that referenced this pull request Apr 6, 2025
…V0.2.1_bug_fixes_arun

Improved DASF mapping to have one to one mapping to SAT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants