Skip to content

Make ApiClient more pyodide friendly#114

Merged
nfx merged 1 commit intomainfrom
not-extend-client
May 17, 2023
Merged

Make ApiClient more pyodide friendly#114
nfx merged 1 commit intomainfrom
not-extend-client

Conversation

@nfx
Copy link
Copy Markdown
Contributor

@nfx nfx commented May 17, 2023

Changes

Embed requests.Session into ApiClient instead of extending it, so that pyodide-http picks it up.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@nfx nfx merged commit afeb4f5 into main May 17, 2023
@nfx nfx deleted the not-extend-client branch May 17, 2023 09:49
nfx added a commit that referenced this pull request May 17, 2023
## Changes
Embed `requests.Session` into ApiClient instead of extending it, so that
`pyodide-http` [picks it
up](https://github.com/koenvo/pyodide-http#supported-packages).

## Tests

- [x] `make test` run locally
- [ ] `make fmt` applied
- [x] relevant integration tests applied
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples ([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)).
* Make ApiClient more `pyodide` friendly ([#114](#114)).
* Persist token acquired through `external-browser` auth type ([#110](#110)).
* Prototype for notebook-native auth ([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)).
* Use shell for opening `az` cli on Windows ([#117](#117)).
@nfx nfx mentioned this pull request May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples
([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount`
([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth
handshake
([#108](#108)).
* Make ApiClient more `pyodide` friendly
([#114](#114)).
* Persist token acquired through `external-browser` auth type
([#110](#110)).
* Prototype for notebook-native auth
([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials`
([#116](#116)).
* Use shell for opening `az` cli on Windows
([#117](#117)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant