Skip to content

Ignore .netrc when sending unauthenticated requests for OAuth handshake#108

Merged
nfx merged 2 commits intodatabricks:mainfrom
susodapop:issue-107
May 17, 2023
Merged

Ignore .netrc when sending unauthenticated requests for OAuth handshake#108
nfx merged 2 commits intodatabricks:mainfrom
susodapop:issue-107

Conversation

@susodapop
Copy link
Copy Markdown

Changes

This PR closes #107 by applying the fix described there.

Tests

Tested manually while developing the same fix for dbt-databricks (see linked issue).

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

Jesse Whitehouse added 2 commits May 12, 2023 16:23
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (5971ba4) 52.72% compared to head (d6c7f8a) 52.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   52.72%   52.72%   -0.01%     
==========================================
  Files          29       29              
  Lines       17067    17071       +4     
==========================================
+ Hits         8998     9000       +2     
- Misses       8069     8071       +2     
Impacted Files Coverage Δ
databricks/sdk/oauth.py 36.51% <50.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit f8d4d1a into databricks:main May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples ([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount` ([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth handshake ([#108](#108)).
* Make ApiClient more `pyodide` friendly ([#114](#114)).
* Persist token acquired through `external-browser` auth type ([#110](#110)).
* Prototype for notebook-native auth ([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials` ([#116](#116)).
* Use shell for opening `az` cli on Windows ([#117](#117)).
@nfx nfx mentioned this pull request May 17, 2023
nfx added a commit that referenced this pull request May 17, 2023
# Version changelog

## 0.1.7

* Added an extensive set of examples
([#113](#113)).
* Fixed broken `dbutils.fs.mount` and `dbutils.fs.updateMount`
([#119](#119)).
* Ignore `.netrc` when sending unauthenticated requests for OAuth
handshake
([#108](#108)).
* Make ApiClient more `pyodide` friendly
([#114](#114)).
* Persist token acquired through `external-browser` auth type
([#110](#110)).
* Prototype for notebook-native auth
([#115](#115)).
* Rename `RefreshableCredentials` to `SessionCredentials`
([#116](#116)).
* Use shell for opening `az` cli on Windows
([#117](#117)).
joyaung pushed a commit to joyaung/databricks-sdk-py that referenced this pull request Apr 6, 2025
…dev_arun_v3_9

Added ability to export SAT check results for a the latest run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth breaks if a bad .netrc file is present

3 participants