-
Notifications
You must be signed in to change notification settings - Fork 193
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: databricks/databricks-sdk-py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.11.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: databricks/databricks-sdk-py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.12.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 39 files changed
- 2 contributors
Commits on Oct 13, 2023
-
Retry on all 429 and 503, even when missing Retry-After header (#402)
## Changes Change HTTP client to always retry on 429 and 503, regardless of whether Retry-After header is present. If absent, default to 1 second, as we do today. Subsumes #391 and #396 while we're still discussing error architecture in the SDK. ## Tests Unit test to ensure that 429 and 503 work with and without Retry-After header.
Configuration menu - View commit details
-
Copy full SHA for 8ee6ff3 - Browse repository at this point
Copy the full SHA 8ee6ff3View commit details
Commits on Oct 18, 2023
-
Add support for tokenless authentication for GitHub Actions configure…
…d with OpenID Connect with Azure User Managed Identity (or Service Principal) (#385) ## Changes See https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers and https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-azure Technically, it should also work with Azure DevOps Workload Identity Federation, once we figure out the environment variables: https://techcommunity.microsoft.com/t5/azure-devops-blog/introduction-to-azure-devops-workload-identity-federation-oidc/ba-p/3908687 ## Tests setup: ``` resource "github_actions_environment_secret" "scope" { for_each = github_repository_environment.default repository = each.value.repository environment = each.value.environment secret_name = "ARM_CLIENT_ID" # this value is not a secret as well plaintext_value = data.azurerm_user_assigned_identity.scopes[local.project_scopes[each.key]].client_id } ... resource "azurerm_federated_identity_credential" "oidc" { for_each = github_repository_environment.default name = "${local.org}-${each.value.repository}-${each.value.environment}-oidc" resource_group_name = local.resource_group_name audience = ["api://AzureADTokenExchange"] issuer = "https://token.actions.githubusercontent.com" parent_id = data.azurerm_user_assigned_identity.scopes[local.project_scopes[each.key]].id subject = "repo:${local.org}/${each.value.repository}:environment:${each.value.environment}" } ... resource "azurerm_user_assigned_identity" "scopes" { for_each = local.scopes name = "labs-${each.key}-identity" resource_group_name = azurerm_resource_group.this.name location = azurerm_resource_group.this.location // ... } ... resource "databricks_service_principal" "scopes" { provider = databricks.account for_each = local.scopes application_id = azurerm_user_assigned_identity.scopes[each.key].client_id display_name = azurerm_user_assigned_identity.scopes[each.key].name external_id = azurerm_user_assigned_identity.scopes[each.key].principal_id } ``` result <img width="603" alt="_Experiment__Call_integration_tests_via_OIDC_·_databrickslabs_ucx_5a94b24" src="https://github.com/databricks/databricks-sdk-py/assets/259697/33b08224-ceed-4c15-bfcd-32e0b58f8483"> - [ ] `make test` run locally - [x] `make fmt` applied - [ ] relevant integration tests applied
Configuration menu - View commit details
-
Copy full SHA for d4c160f - Browse repository at this point
Copy the full SHA d4c160fView commit details
Commits on Oct 23, 2023
-
Reduce redundant warning messages in azure-cli credential provider (#410
) ## Changes This warning is a bit noisy: in the happy path, we print it multiple times, and even if we don't use Azure CLI auth, we may print it anyways. Also, it will be printed always when using account-level authentication. This PR reduces the noise for this warning by only printing it when we are certainly going to use Azure CLI auth, authenticating to a workspace, and can't get the subscription ID (e.g. because it is not configured). ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] Ran locally: with accounts client, no warning is printed, and with workspace client, only one warning is printed.
Configuration menu - View commit details
-
Copy full SHA for f29ad4a - Browse repository at this point
Copy the full SHA f29ad4aView commit details
Commits on Oct 24, 2023
-
* Retry on all 429 and 503, even when missing Retry-After header ([#402](#402)). * Add support for tokenless authentication for GitHub Actions configured with OpenID Connect with Azure User Managed Identity (or Service Principal) ([#385](#385)). * Reduce redundant warning messages in azure-cli credential provider ([#410](#410)). API Changes: * Added `attributes`, `count`, `excluded_attributes`, `filter`, `sort_by`, `sort_order`, and `start_index` fields for `databricks.sdk.service.iam.GetAccountUserRequest` and `databricks.sdk.service.iam.GetUserRequest`. * Added `schemas` field for `databricks.sdk.service.iam.Group`, `databricks.sdk.service.iam.ListGroupsResponse`, `databricks.sdk.service.iam.ListServicePrincipalResponse`, `databricks.sdk.service.iam.ListUsersResponse`, `databricks.sdk.service.iam.ServicePrincipal`, and `databricks.sdk.service.iam.User`. * Added `databricks.sdk.service.iam.GetSortOrder`, `databricks.sdk.service.iam.GroupSchema`, `databricks.sdk.service.iam.ListResponseSchema`, `databricks.sdk.service.iam.ServicePrincipalSchema`, and `databricks.sdk.service.iam.UserSchema` dataclasses. * Added `webhook_notifications` field for `databricks.sdk.service.jobs.SubmitTask`. * Added [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service and related dataclasses * Added [a.account_network_policy](https://databricks-sdk-py.readthedocs.io/en/latest/account/account_network_policy.html) account-level service and related dataclasses. OpenAPI SHA: 5903bb39137fd76ac384b2044e425f9c56840e00, Date: 2023-10-23
Configuration menu - View commit details
-
Copy full SHA for 5b68d71 - Browse repository at this point
Copy the full SHA 5b68d71View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.11.0...v0.12.0