Skip to content

Test parsing of error messages with int error codes#303

Merged
mgyucht merged 3 commits intomainfrom
rh/parse-int-error-code
Jul 5, 2024
Merged

Test parsing of error messages with int error codes#303
mgyucht merged 3 commits intomainfrom
rh/parse-int-error-code

Conversation

@renaudhartert-db
Copy link
Copy Markdown
Contributor

@renaudhartert-db renaudhartert-db commented Jul 3, 2024

Changes

The /api/2.0/preview/scim/v2/Me sometime returns the HTTP status (an int) as error code (which is expected to be a string). This is not a problem in the Java SDK because Jackson automatically converts numbers to strings. This PR makes it clear that this behavior is intended by adding a test for it.

@renaudhartert-db renaudhartert-db changed the title Add test for int error codes Test parsing of error messages with int error codes. Jul 3, 2024
@renaudhartert-db renaudhartert-db changed the title Test parsing of error messages with int error codes. Test parsing of error messages with int error codes Jul 3, 2024
@renaudhartert-db renaudhartert-db marked this pull request as ready for review July 3, 2024 11:12
@renaudhartert-db renaudhartert-db requested a review from mgyucht July 3, 2024 11:13
Copy link
Copy Markdown
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, thanks!

@mgyucht mgyucht added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit a618a4b Jul 5, 2024
@mgyucht mgyucht deleted the rh/parse-int-error-code branch July 5, 2024 10:03
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
## Changes
Improve Changelog by grouping changes

## Tests
Recreated latest release Changelog:
```
Release v0.27.0

### Other Changes

 * Add `serverless_compute_id` field to the config ([#299](#299)).
 * Ignore DataPlane Services during generation ([#296](#296)).
 * Release v0.27.0 ([#301](#301)).
 * Retry failed integration tests ([#298](#298)).
 * Support partners in SDK ([#291](#291)).
 * Test parsing of error messages with `int` error codes ([#303](#303)).
 * Update OpenAPI spec ([#297](#297)).


### API Changes:

 * Added `workspaceClient.servingEndpointsDataPlane()` service.
 * Added `deploy()` and `start()` methods for `workspaceClient.apps()` service.
 * Added `batchGet()` method for `workspaceClient.consumerListings()` service.
 * Added `batchGet()` method for `workspaceClient.consumerProviders()` service.
 * Added `createSchedule()`, `createSubscription()`, `deleteSchedule()`, `deleteSubscription()`, `getSchedule()`, `getSubscription()`, `list()`, `listSchedules()`, `listSubscriptions()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service.
 * Added `queryNextPage()` method for `workspaceClient.vectorSearchIndexes()` service.
 * Added `com.databricks.sdk.service.serving.AppDeploymentMode`, `com.databricks.sdk.service.serving.ModelDataPlaneInfo` and `com.databricks.sdk.service.serving.StartAppRequest` classes.
 * Added `com.databricks.sdk.service.catalog.CatalogIsolationMode` and `com.databricks.sdk.service.catalog.ListAccountStorageCredentialsResponse` classes.
 * Added `com.databricks.sdk.service.dashboards.CreateScheduleRequest`, `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`, `com.databricks.sdk.service.dashboards.CronSchedule`, `com.databricks.sdk.service.dashboards.DashboardView`, `com.databricks.sdk.service.dashboards.DeleteScheduleRequest`, `Object`, `com.databricks.sdk.service.dashboards.DeleteSubscriptionRequest`, `Object`, `com.databricks.sdk.service.dashboards.GetScheduleRequest`, `com.databricks.sdk.service.dashboards.GetSubscriptionRequest`, `com.databricks.sdk.service.dashboards.ListDashboardsRequest`, `com.databricks.sdk.service.dashboards.ListDashboardsResponse`, `com.databricks.sdk.service.dashboards.ListSchedulesRequest`, `com.databricks.sdk.service.dashboards.ListSchedulesResponse`, `com.databricks.sdk.service.dashboards.ListSubscriptionsRequest`, `com.databricks.sdk.service.dashboards.ListSubscriptionsResponse`, `com.databricks.sdk.service.dashboards.Schedule`, `com.databricks.sdk.service.dashboards.SchedulePauseStatus`, `com.databricks.sdk.service.dashboards.Subscriber`, `com.databricks.sdk.service.dashboards.Subscription`, `com.databricks.sdk.service.dashboards.SubscriptionSubscriberDestination`, `com.databricks.sdk.service.dashboards.SubscriptionSubscriberUser` and `com.databricks.sdk.service.dashboards.UpdateScheduleRequest` classes.
 * Added `com.databricks.sdk.service.jobs.PeriodicTriggerConfiguration` and `com.databricks.sdk.service.jobs.PeriodicTriggerConfigurationTimeUnit` classes.
 * Added `com.databricks.sdk.service.marketplace.BatchGetListingsRequest`, `com.databricks.sdk.service.marketplace.BatchGetListingsResponse`, `com.databricks.sdk.service.marketplace.BatchGetProvidersRequest`, `com.databricks.sdk.service.marketplace.BatchGetProvidersResponse`, `com.databricks.sdk.service.marketplace.ProviderIconFile`, `com.databricks.sdk.service.marketplace.ProviderIconType` and `com.databricks.sdk.service.marketplace.ProviderListingSummaryInfo` classes.
 * Added `com.databricks.sdk.service.oauth2.DataPlaneInfo` class.
 * Added `com.databricks.sdk.service.vectorsearch.QueryVectorIndexNextPageRequest` class.
 * Added `isolationMode` field for `com.databricks.sdk.service.catalog.ExternalLocationInfo`.
 * Added `maxResults` and `pageToken` fields for `com.databricks.sdk.service.catalog.ListCatalogsRequest`.
 * Added `nextPageToken` field for `com.databricks.sdk.service.catalog.ListCatalogsResponse`.
 * Added `tableServingUrl` field for `com.databricks.sdk.service.catalog.OnlineTable`.
```
tanmay-db added a commit that referenced this pull request Jul 10, 2024
### New Features and Improvements

 * Specify proxy auth explicitly when using system proxy ([#300](#300)).

### Internal Changes

 * Add Release tag and Workflow Fix ([#309](#309)).
 * Improve Changelog by grouping changes ([#308](#308)).

### Other Changes

 * Accept any `HttpRequest` instead of `HttpUriRequest` in `CommonHttpClient` ([#305](#305)).
 * Test parsing of error messages with `int` error codes ([#303](#303)).
@tanmay-db tanmay-db mentioned this pull request Jul 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
## 0.27.1

### New Features and Improvements
* Specify proxy auth explicitly when using system proxy
([#300](#300)).
* Accept any `HttpRequest` instead of `HttpUriRequest` in
`CommonHttpClient`
([#305](#305)).
* Add credential provider for Azure Github OIDC
([#307](#307)).

### Internal Changes
* Add Release tag and Workflow Fix
([#309](#309)).
* Improve Changelog by grouping changes
([#308](#308)).
* Test parsing of error messages with `int` error codes
([#303](#303)).
* Run AccountClientIT test only for aws-prod-ucacct
([#311](#311)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants