Conversation
tanmay-db
approved these changes
Feb 12, 2024
tanmay-db
added a commit
that referenced
this pull request
Mar 4, 2024
* Reading headers should be done in a case-insensitive manner ([#235](#235)). * Fix getWorkspaceClient() for GCP ([#224](#224)). * Add integration tests for the Files API ([#236](#236)). * Support subservices ([#237](#237)). * Handle empty types in the Java SDK ([#239](#239)). * Add basic support for HTTP proxies ([#241](#241)). * Added tokei.rs lines of code badge ([#243](#243)). * Update SDK to latest OpenAPI spec ([#245](#245)). API Changes: * Added `workspaceClient.permissionMigration()` service. * Added `com.databricks.sdk.service.iam.PermissionMigrationRequest` class. * Added `com.databricks.sdk.service.iam.PermissionMigrationResponse` class. * Changed `version` field for `com.databricks.sdk.service.serving.AppManifest` to `com.databricks.sdk.service.serving.AnyValue` class. * Removed `deletePersonalComputeSetting()` method for `accountClient.settings()` service. * Removed `getPersonalComputeSetting()` method for `accountClient.settings()` service. * Removed `updatePersonalComputeSetting()` method for `accountClient.settings()` service. * Removed `deleteDefaultNamespaceSetting()` method for `workspaceClient.settings()` service. * Removed `deleteRestrictWorkspaceAdminsSetting()` method for `workspaceClient.settings()` service. * Removed `getDefaultNamespaceSetting()` method for `workspaceClient.settings()` service. * Removed `getRestrictWorkspaceAdminsSetting()` method for `workspaceClient.settings()` service. * Removed `updateDefaultNamespaceSetting()` method for `workspaceClient.settings()` service. * Removed `updateRestrictWorkspaceAdminsSetting()` method for `workspaceClient.settings()` service. * Added `workspaceClient.automaticClusterUpdate()` service. * Added `workspaceClient.cspEnablement()` service. * Added `accountClient.cspEnablementAccount()` service. * Added `workspaceClient.defaultNamespace()` service. * Added `workspaceClient.esmEnablement()` service. * Added `accountClient.esmEnablementAccount()` service. * Added `accountClient.personalCompute()` service. * Added `workspaceClient.restrictWorkspaceAdmins()` service. * Removed `com.databricks.sdk.service.settings.DeleteDefaultNamespaceSettingRequest` class. * Removed `com.databricks.sdk.service.settings.DeletePersonalComputeSettingRequest` class. * Removed `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingRequest` class. * Removed `com.databricks.sdk.service.settings.GetDefaultNamespaceSettingRequest` class. * Removed `com.databricks.sdk.service.settings.GetPersonalComputeSettingRequest` class. * Removed `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminsSettingRequest` class. * Added `awsStableIpRule` field for `com.databricks.sdk.service.settings.NccEgressDefaultRules`. * Added `com.databricks.sdk.service.settings.AutomaticClusterUpdateSetting` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessage` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageEnablementDetails` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindow` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowDayOfWeek` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayBasedSchedule` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayFrequency` class. * Added `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWindowStartTime` class. * Added `com.databricks.sdk.service.settings.ComplianceStandard` class. * Added `com.databricks.sdk.service.settings.CspEnablement` class. * Added `com.databricks.sdk.service.settings.CspEnablementAccount` class. * Added `com.databricks.sdk.service.settings.CspEnablementAccountSetting` class. * Added `com.databricks.sdk.service.settings.CspEnablementSetting` class. * Added `com.databricks.sdk.service.settings.DeleteDefaultNamespaceRequest` class. * Added `com.databricks.sdk.service.settings.DeletePersonalComputeRequest` class. * Added `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminRequest` class. * Added `com.databricks.sdk.service.settings.EsmEnablement` class. * Added `com.databricks.sdk.service.settings.EsmEnablementAccount` class. * Added `com.databricks.sdk.service.settings.EsmEnablementAccountSetting` class. * Added `com.databricks.sdk.service.settings.EsmEnablementSetting` class. * Added `com.databricks.sdk.service.settings.GetAutomaticClusterUpdateRequest` class. * Added `com.databricks.sdk.service.settings.GetCspEnablementAccountRequest` class. * Added `com.databricks.sdk.service.settings.GetCspEnablementRequest` class. * Added `com.databricks.sdk.service.settings.GetDefaultNamespaceRequest` class. * Added `com.databricks.sdk.service.settings.GetEsmEnablementAccountRequest` class. * Added `com.databricks.sdk.service.settings.GetEsmEnablementRequest` class. * Added `com.databricks.sdk.service.settings.GetPersonalComputeRequest` class. * Added `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminRequest` class. * Added `com.databricks.sdk.service.settings.NccAwsStableIpRule` class. * Added `com.databricks.sdk.service.settings.UpdateAutomaticClusterUpdateSettingRequest` class. * Added `com.databricks.sdk.service.settings.UpdateCspEnablementAccountSettingRequest` class. * Added `com.databricks.sdk.service.settings.UpdateCspEnablementSettingRequest` class. * Added `com.databricks.sdk.service.settings.UpdateEsmEnablementAccountSettingRequest` class. * Added `com.databricks.sdk.service.settings.UpdateEsmEnablementSettingRequest` class. * Removed `planningPhases` field for `com.databricks.sdk.service.sql.QueryMetrics`. * Changed `deleteEndpoint()` method for `workspaceClient.vectorSearchEndpoints()` service with new required argument order. * Changed `createIndex()` method for `workspaceClient.vectorSearchIndexes()` service with new required argument order. * Changed `deleteDataVectorIndex()` method for `workspaceClient.vectorSearchIndexes()` service with new required argument order. * Changed `upsertDataVectorIndex()` method for `workspaceClient.vectorSearchIndexes()` service with new required argument order. * Changed `endpointName` field for `com.databricks.sdk.service.vectorsearch.CreateVectorIndexRequest` to be required. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteEndpointRequest`. * Removed `com.databricks.sdk.service.vectorsearch.EmbeddingConfig` class. * Removed `embeddingConfig` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Added `embeddingModelEndpointName` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Removed `deltaSyncVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Removed `directAccessVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Added `deltaSyncIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Added `directAccessIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. OpenAPI SHA: d855b30f25a06fe84f25214efa20e7f1fffcdf9e, Date: 2024-03-04
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
## 0.20.0 ### Features and Improvements * Added basic support for HTTP proxies ([#241](#241)). * Fixed getWorkspaceClient() for GCP ([#224](#224)). * Note: Backwards incompatible changes - Settings are now nested, please see the API changes below. ### Internal Changes * Reading headers should be done in a case-insensitive manner ([#235](#235)). * Added integration tests for the Files API ([#236](#236)). * Supported subservices ([#237](#237)). * Handled empty types in the Java SDK ([#239](#239)). * Added tokei.rs lines of code badge ([#243](#243)). * Updated SDK to latest OpenAPI spec ([#245](#245)). ### API Changes: * Added the following services: - `workspaceClient.permissionMigration()` - `workspaceClient.automaticClusterUpdate()` - `workspaceClient.cspEnablement()` - `accountClient.cspEnablementAccount()` - `workspaceClient.defaultNamespace()` - `workspaceClient.esmEnablement()` - `accountClient.esmEnablementAccount()` - `accountClient.personalCompute()` - `workspaceClient.restrictWorkspaceAdmins()` * Added the following classes: - `com.databricks.sdk.service.iam.PermissionMigrationRequest` - `com.databricks.sdk.service.iam.PermissionMigrationResponse` - `com.databricks.sdk.service.settings.AutomaticClusterUpdateSetting` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessage` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageEnablementDetails` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindow` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowDayOfWeek` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayBasedSchedule` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayFrequency` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWindowStartTime` - `com.databricks.sdk.service.settings.ComplianceStandard` - `com.databricks.sdk.service.settings.CspEnablement` - `com.databricks.sdk.service.settings.CspEnablementAccount` - `com.databricks.sdk.service.settings.CspEnablementAccountSetting` - `com.databricks.sdk.service.settings.CspEnablementSetting` - `com.databricks.sdk.service.settings.DeleteDefaultNamespaceRequest` - `com.databricks.sdk.service.settings.DeletePersonalComputeRequest` - `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminRequest` - `com.databricks.sdk.service.settings.EsmEnablement` - `com.databricks.sdk.service.settings.EsmEnablementAccount` - `com.databricks.sdk.service.settings.EsmEnablementAccountSetting` - `com.databricks.sdk.service.settings.EsmEnablementSetting` - `com.databricks.sdk.service.settings.GetAutomaticClusterUpdateRequest` - `com.databricks.sdk.service.settings.GetCspEnablementAccountRequest` - `com.databricks.sdk.service.settings.GetCspEnablementRequest` - `com.databricks.sdk.service.settings.GetDefaultNamespaceRequest` - `com.databricks.sdk.service.settings.GetEsmEnablementAccountRequest` - `com.databricks.sdk.service.settings.GetEsmEnablementRequest` - `com.databricks.sdk.service.settings.GetPersonalComputeRequest` - `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminRequest` - `com.databricks.sdk.service.settings.NccAwsStableIpRule` - `com.databricks.sdk.service.settings.UpdateAutomaticClusterUpdateSettingRequest` - `com.databricks.sdk.service.settings.UpdateCspEnablementAccountSettingRequest` - `com.databricks.sdk.service.settings.UpdateCspEnablementSettingRequest` - `com.databricks.sdk.service.settings.UpdateEsmEnablementAccountSettingRequest` - `com.databricks.sdk.service.settings.UpdateEsmEnablementSettingRequest` * Removed the follogin classes: - `com.databricks.sdk.service.settings.DeleteDefaultNamespaceSettingRequest` - `com.databricks.sdk.service.settings.DeletePersonalComputeSettingRequest` - `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingRequest` - `com.databricks.sdk.service.settings.GetDefaultNamespaceSettingRequest` - `com.databricks.sdk.service.settings.GetPersonalComputeSettingRequest` - `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminsSettingRequest` * Changed `version` field for `com.databricks.sdk.service.serving.AppManifest` to `com.databricks.sdk.service.serving.AnyValue` class. * Removed `deletePersonalComputeSetting()`, `getPersonalComputeSetting()` and `updatePersonalComputeSetting()` method for `accountClient.settings()` service. * Removed `deleteDefaultNamespaceSetting()`, `deleteRestrictWorkspaceAdminsSetting()`, `getDefaultNamespaceSetting()`, `getRestrictWorkspaceAdminsSetting()`, `updateDefaultNamespaceSetting()` and `updateRestrictWorkspaceAdminsSetting()` method for `workspaceClient.settings()` service. * Added `awsStableIpRule` field for `com.databricks.sdk.service.settings.NccEgressDefaultRules`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Added `embeddingModelEndpointName` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Added `deltaSyncIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Added `directAccessIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Changed `deleteEndpoint()`, `createIndex()`, `deleteDataVectorIndex()` and `upsertDataVectorIndex()` method for `workspaceClient.vectorSearchEndpoints()` service with new required argument order. * Changed `endpointName` field for `com.databricks.sdk.service.vectorsearch.CreateVectorIndexRequest` to be required. * Removed `planningPhases` field for `com.databricks.sdk.service.sql.QueryMetrics`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteEndpointRequest`. * Removed `com.databricks.sdk.service.vectorsearch.EmbeddingConfig` class. * Removed `embeddingConfig` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Removed `deltaSyncVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Removed `directAccessVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. OpenAPI SHA: d855b30f25a06fe84f25214efa20e7f1fffcdf9e, Date: 2024-03-04
vikrantpuppala
pushed a commit
to vikrantpuppala/databricks-sdk-java
that referenced
this pull request
Apr 23, 2024
## 0.20.0 ### Features and Improvements * Added basic support for HTTP proxies ([databricks#241](databricks#241)). * Fixed getWorkspaceClient() for GCP ([databricks#224](databricks#224)). * Note: Backwards incompatible changes - Settings are now nested, please see the API changes below. ### Internal Changes * Reading headers should be done in a case-insensitive manner ([databricks#235](databricks#235)). * Added integration tests for the Files API ([databricks#236](databricks#236)). * Supported subservices ([databricks#237](databricks#237)). * Handled empty types in the Java SDK ([databricks#239](databricks#239)). * Added tokei.rs lines of code badge ([databricks#243](databricks#243)). * Updated SDK to latest OpenAPI spec ([databricks#245](databricks#245)). ### API Changes: * Added the following services: - `workspaceClient.permissionMigration()` - `workspaceClient.automaticClusterUpdate()` - `workspaceClient.cspEnablement()` - `accountClient.cspEnablementAccount()` - `workspaceClient.defaultNamespace()` - `workspaceClient.esmEnablement()` - `accountClient.esmEnablementAccount()` - `accountClient.personalCompute()` - `workspaceClient.restrictWorkspaceAdmins()` * Added the following classes: - `com.databricks.sdk.service.iam.PermissionMigrationRequest` - `com.databricks.sdk.service.iam.PermissionMigrationResponse` - `com.databricks.sdk.service.settings.AutomaticClusterUpdateSetting` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessage` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageEnablementDetails` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindow` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowDayOfWeek` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayBasedSchedule` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWeekDayFrequency` - `com.databricks.sdk.service.settings.ClusterAutoRestartMessageMaintenanceWindowWindowStartTime` - `com.databricks.sdk.service.settings.ComplianceStandard` - `com.databricks.sdk.service.settings.CspEnablement` - `com.databricks.sdk.service.settings.CspEnablementAccount` - `com.databricks.sdk.service.settings.CspEnablementAccountSetting` - `com.databricks.sdk.service.settings.CspEnablementSetting` - `com.databricks.sdk.service.settings.DeleteDefaultNamespaceRequest` - `com.databricks.sdk.service.settings.DeletePersonalComputeRequest` - `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminRequest` - `com.databricks.sdk.service.settings.EsmEnablement` - `com.databricks.sdk.service.settings.EsmEnablementAccount` - `com.databricks.sdk.service.settings.EsmEnablementAccountSetting` - `com.databricks.sdk.service.settings.EsmEnablementSetting` - `com.databricks.sdk.service.settings.GetAutomaticClusterUpdateRequest` - `com.databricks.sdk.service.settings.GetCspEnablementAccountRequest` - `com.databricks.sdk.service.settings.GetCspEnablementRequest` - `com.databricks.sdk.service.settings.GetDefaultNamespaceRequest` - `com.databricks.sdk.service.settings.GetEsmEnablementAccountRequest` - `com.databricks.sdk.service.settings.GetEsmEnablementRequest` - `com.databricks.sdk.service.settings.GetPersonalComputeRequest` - `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminRequest` - `com.databricks.sdk.service.settings.NccAwsStableIpRule` - `com.databricks.sdk.service.settings.UpdateAutomaticClusterUpdateSettingRequest` - `com.databricks.sdk.service.settings.UpdateCspEnablementAccountSettingRequest` - `com.databricks.sdk.service.settings.UpdateCspEnablementSettingRequest` - `com.databricks.sdk.service.settings.UpdateEsmEnablementAccountSettingRequest` - `com.databricks.sdk.service.settings.UpdateEsmEnablementSettingRequest` * Removed the follogin classes: - `com.databricks.sdk.service.settings.DeleteDefaultNamespaceSettingRequest` - `com.databricks.sdk.service.settings.DeletePersonalComputeSettingRequest` - `com.databricks.sdk.service.settings.DeleteRestrictWorkspaceAdminsSettingRequest` - `com.databricks.sdk.service.settings.GetDefaultNamespaceSettingRequest` - `com.databricks.sdk.service.settings.GetPersonalComputeSettingRequest` - `com.databricks.sdk.service.settings.GetRestrictWorkspaceAdminsSettingRequest` * Changed `version` field for `com.databricks.sdk.service.serving.AppManifest` to `com.databricks.sdk.service.serving.AnyValue` class. * Removed `deletePersonalComputeSetting()`, `getPersonalComputeSetting()` and `updatePersonalComputeSetting()` method for `accountClient.settings()` service. * Removed `deleteDefaultNamespaceSetting()`, `deleteRestrictWorkspaceAdminsSetting()`, `getDefaultNamespaceSetting()`, `getRestrictWorkspaceAdminsSetting()`, `updateDefaultNamespaceSetting()` and `updateRestrictWorkspaceAdminsSetting()` method for `workspaceClient.settings()` service. * Added `awsStableIpRule` field for `com.databricks.sdk.service.settings.NccEgressDefaultRules`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Added `embeddingModelEndpointName` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Added `indexName` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Added `deltaSyncIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Added `directAccessIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Changed `deleteEndpoint()`, `createIndex()`, `deleteDataVectorIndex()` and `upsertDataVectorIndex()` method for `workspaceClient.vectorSearchEndpoints()` service with new required argument order. * Changed `endpointName` field for `com.databricks.sdk.service.vectorsearch.CreateVectorIndexRequest` to be required. * Removed `planningPhases` field for `com.databricks.sdk.service.sql.QueryMetrics`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteDataVectorIndexRequest`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.DeleteEndpointRequest`. * Removed `com.databricks.sdk.service.vectorsearch.EmbeddingConfig` class. * Removed `embeddingConfig` field for `com.databricks.sdk.service.vectorsearch.EmbeddingSourceColumn`. * Removed `name` field for `com.databricks.sdk.service.vectorsearch.UpsertDataVectorIndexRequest`. * Removed `deltaSyncVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. * Removed `directAccessVectorIndexSpec` field for `com.databricks.sdk.service.vectorsearch.VectorIndex`. OpenAPI SHA: d855b30f25a06fe84f25214efa20e7f1fffcdf9e, Date: 2024-03-04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The current implementation of getWorkspaceClient() copies the entire config, critically reusing the cached header factory so as to use the same auth mechanism when getting a workspace client. However, at least in GCP, account-level OAuth tokens can't be used to authenticate to a workspace (probably because the audience for the account-level and workspace-level tokens is different).
This PR fixes this by copying all fields except for the auth type and header factory. Subsequent use of the config in WorkspaceClient will trigger config resolution. For GCP, this means creating a new token source using the correct host as the audience.
This ports databricks/databricks-sdk-go#803 to the Java SDK.
Tests
Manually ran this integration test in all non-UC (Azure, AWS, GCP) and UC (AWS, GCP) account-level environments.