Mock HTTP client in accounts OIDC test to avoid hitting live endpoint

hectorcast-db · hectorcast-db · commit 781014576dad · 2026-03-31T10:00:32.000Z
The openIDConnectEndPointsTestAccounts test was making real HTTP calls
to accounts.cloud.databricks.com, causing failures when the endpoint
returned HTML instead of JSON. Use a mock HttpClient that stubs the
host metadata call, since account OIDC endpoints are computed locally.
Also apply spotless formatting fixes.

Co-authored-by: Isaac
diff --git a/databricks-sdk-java/src/test/java/com/databricks/sdk/core/UnifiedHostTest.java b/databricks-sdk-java/src/test/java/com/databricks/sdk/core/UnifiedHostTest.java
@@ -90,9 +90,7 @@ public void testIsAccountClientForWorkspaceHost() {
   public void testIsAccountClientForNonAccountsHost() {
     // Non-accounts hosts are not account clients
     assertFalse(
-        new DatabricksConfig()
-            .setHost("https://mycompany.databricks.com")
-            .isAccountClient());
+        new DatabricksConfig().setHost("https://mycompany.databricks.com").isAccountClient());
   }
 
   // --- Environment Variable Tests ---
diff --git a/databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProviderTest.java b/databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProviderTest.java
@@ -122,11 +122,27 @@ void clientAndConsentTestWithCustomRedirectUrl() throws IOException {
 
   @Test
   void openIDConnectEndPointsTestAccounts() throws IOException {
+    HttpClient mockHttpClient = Mockito.mock(HttpClient.class);
+    // Mock the host metadata call (resolve) to return 404, matching FixtureServer auto-stub
+    // behavior. The actual OIDC endpoints for account clients are computed locally without HTTP.
+    Mockito.doAnswer(
+            invocation -> {
+              Request req = invocation.getArgument(0);
+              if (req.getUrl().contains("/.well-known/databricks-config")) {
+                return new Response(
+                    "{\"error_code\":\"NOT_FOUND\",\"message\":\"not found\"}",
+                    new URL(req.getUrl()));
+              }
+              throw new IOException("Unexpected request: " + req.getUrl());
+            })
+        .when(mockHttpClient)
+        .execute(any(Request.class));
+
     DatabricksConfig config =
         new DatabricksConfig()
             .setAuthType("external-browser")
             .setHost("https://accounts.cloud.databricks.com")
-            .setHttpClient(new CommonsHttpClient.Builder().withTimeoutSeconds(30).build())
+            .setHttpClient(mockHttpClient)
             .setAccountId("testAccountId");
     config.resolve();
 
diff --git a/databricks-sdk-java/src/test/java/com/databricks/sdk/service/gentesting/unittests/IdempotencyTestingAPITest.java b/databricks-sdk-java/src/test/java/com/databricks/sdk/service/gentesting/unittests/IdempotencyTestingAPITest.java
