[Fix] Avoid loading the response bodies twice in memory when parsing bytes.Buffer#984
Merged
renaudhartert-db merged 6 commits intomainfrom Jul 17, 2024
Merged
[Fix] Avoid loading the response bodies twice in memory when parsing bytes.Buffer#984renaudhartert-db merged 6 commits intomainfrom
bytes.Buffer#984renaudhartert-db merged 6 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this PR,
WithResponseUnmarshalwas unmarshalling a response body to abytes.Bufferby:bytes.Buffer.Step 1 unnecessarily increases the memory footprint as the response body is essentially stored twice in memory during unmarshalling. This PR fixes that problem by loading the body directly in the buffer without passing by an intermediate container.
Tests
Added a few unit test to cover all unmarshalling types.
Memory benchmark:
Results:
make testpassingmake fmtapplied