SDK Generation + Fix backwards incompatible changes by tanmay-db · Pull Request #806 · databricks/databricks-sdk-go

tanmay-db · 2024-02-08T14:13:03Z

Changes

Update SDK to OpenAPI spec and fix backwards incompatible change

Tests

make test passing
make fmt applied
relevant integration tests applied

tanmay-db · 2024-02-08T14:28:25Z

internal/catalog_test.go


 	_, err = w.Metastores.Update(ctx, catalog.UpdateMetastore{
-		Id:   created.MetastoreId,
-		Name: RandomName("go-sdk-updated"),


Fine. This is not necessary for Metastore (since the name is not the path parameter) but better for consistency.

tanmay-db · 2024-02-08T14:29:04Z

internal/connections_test.go

 	})

 	connUpdate, err := w.Connections.Update(ctx, catalog.UpdateConnection{
-		Name:    connCreate.Name,


we don't need this

Shouldn't we be removing NameArg instead of Name?

I guess that change didn't make it through...

tanmay-db · 2024-02-08T14:29:16Z

service/catalog/connections_usage_test.go

 	logger.Infof(ctx, "found %v", connCreate)

 	connUpdate, err := w.Connections.Update(ctx, catalog.UpdateConnection{
-		Name:    connCreate.Name,


tanmay-db · 2024-02-08T14:29:22Z

service/catalog/metastores_usage_test.go

-		Id:   created.MetastoreId,
-		Name: fmt.Sprintf("sdk-%x", time.Now().UnixNano()),
+		Id:      created.MetastoreId,
+		NewName: fmt.Sprintf("sdk-%x", time.Now().UnixNano()),


codecov-commenter · 2024-02-08T14:29:25Z

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (219f9e0) 18.61% compared to head (6e18e22) 18.53%.

Files	Patch %	Lines
service/settings/model.go	0.00%	39 Missing ⚠️
service/settings/impl.go	0.00%	29 Missing ⚠️
service/catalog/impl.go	0.00%	26 Missing ⚠️
service/catalog/api.go	0.00%	17 Missing ⚠️
service/catalog/model.go	0.00%	17 Missing ⚠️
service/jobs/model.go	0.00%	16 Missing ⚠️
service/settings/api.go	0.00%	14 Missing ⚠️
service/pipelines/model.go	0.00%	11 Missing ⚠️
service/compute/model.go	0.00%	4 Missing ⚠️
service/workspace/model.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   18.61%   18.53%   -0.09%     
==========================================
  Files         116      116              
  Lines       21377    21474      +97     
==========================================
  Hits         3980     3980              
- Misses      17153    17250      +97     
  Partials      244      244

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mgyucht

Need to check on removal of pipeline reset with @pietern.

mgyucht · 2024-02-08T14:46:43Z

internal/catalog_test.go


 	_, err = w.Metastores.Update(ctx, catalog.UpdateMetastore{
-		Id:   created.MetastoreId,
-		Name: RandomName("go-sdk-updated"),


Fine. This is not necessary for Metastore (since the name is not the path parameter) but better for consistency.

mgyucht · 2024-02-08T14:47:09Z

internal/connections_test.go

 	})

 	connUpdate, err := w.Connections.Update(ctx, catalog.UpdateConnection{
-		Name:    connCreate.Name,


Shouldn't we be removing NameArg instead of Name?

mgyucht · 2024-02-08T14:52:07Z

service/pipelines/api.go

-	// Reset a pipeline.
-	//
-	// Resets a pipeline.
-	Reset(ctx context.Context, resetRequest ResetRequest) (*WaitGetPipelineRunning[struct{}], error)


Was this method removed?

mgyucht

LGTM

tanmay-db added 3 commits February 8, 2024 15:12

SDK Generation

304f8c7

SDK Generation

7cbd3bd

SDK Generation

685031d

tanmay-db requested review from edwardfeng-db, hectorcast-db and mgyucht February 8, 2024 14:19

tanmay-db changed the title ~~SDK Generation~~ SDK Generation + Fix backward incompatible changes Feb 8, 2024

tanmay-db added 2 commits February 8, 2024 15:26

SDK Generation

19c97fc

SDK Generation

6e18e22

tanmay-db changed the title ~~SDK Generation + Fix backward incompatible changes~~ SDK Generation + Fix backwards incompatible changes Feb 8, 2024

tanmay-db commented Feb 8, 2024

View reviewed changes

mgyucht reviewed Feb 8, 2024

View reviewed changes

mgyucht approved these changes Feb 8, 2024

View reviewed changes

tanmay-db added this pull request to the merge queue Feb 8, 2024

Merged via the queue into main with commit ea52c05 Feb 8, 2024

tanmay-db deleted the testing-apply branch February 8, 2024 15:22

tanmay-db mentioned this pull request Feb 8, 2024

Release v0.31.0 #807

Merged

renaudhartert-db mentioned this pull request Mar 28, 2026

[ISSUE] destination field in the structures for init script configurations is marked omitempty although it's required #610

Closed

Conversation

tanmay-db commented Feb 8, 2024

Changes

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Feb 8, 2024

Codecov Report

Uh oh!

mgyucht left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgyucht left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants