Use per-config refresh context for OAuth tokens#728
Merged
Conversation
This PR uses per-conflig refresh context for all oauth2 tokens, so that it's separate from the context coming in the first request (as before)
pietern
reviewed
Dec 4, 2023
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Why does it need to be separate?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 17.58% 17.62% +0.04%
==========================================
Files 103 103
Lines 14191 14197 +6
==========================================
+ Hits 2495 2502 +7
+ Misses 11491 11490 -1
Partials 205 205 ☔ View full report in Codecov by Sentry. |
Contributor
|
@pietern because request contexts can have a timeout, but Go's OAuth2 lib caches the context used to create the token source, so we need to be very sure to use a separate context without a timeout. |
mgyucht
approved these changes
Dec 4, 2023
Comment on lines
+41
to
+42
| StatusCode: statusCode, | ||
| Status: status, |
mgyucht
added a commit
that referenced
this pull request
Dec 7, 2023
This is a bugfix release, including a fix correcting issues with OAuth flows, due to a bug with the propagation of the response status in `httpclient`'s `RoundTrip()` implementation. This fixes the `failed during request visitor: token: oauth2: cannot fetch token: Response: {...}` error.
All fixes:
* Migrate Azure MSI & Metadata Service token sources to `httpclient` and add 100% test coverage ([#709](#709)).
* Added `config.NewAzureCliTokenSource` and `config.NewAzureMsiTokenSource` constructors ([#727](#727)).
* Use per-config refresh context for OAuth tokens ([#728](#728)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
This is a bugfix release, including a fix correcting issues with OAuth
flows, due to a bug with the propagation of the response status in
`httpclient`'s `RoundTrip()` implementation. This fixes the `failed
during request visitor: token: oauth2: cannot fetch token: Response:
{...}` error.
All fixes:
* Migrate Azure MSI & Metadata Service token sources to `httpclient` and
add 100% test coverage
([#709](#709)).
* Added `config.NewAzureCliTokenSource` and
`config.NewAzureMsiTokenSource` constructors
([#727](#727)).
* Use per-config refresh context for OAuth tokens
([#728](#728)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR uses per-config refresh context for all oauth2 tokens, so that it's separate from the context coming in the first request (as before)
Tests
make testpassingmake fmtapplied