Closed
Conversation
Fundamentally prevent regressions like
```
PUT /api/2.0/fs/files//Volumes/main/x/y/z
> [non-JSON document of 11 bytes]. <io.Reader>
< HTTP/2.0 400 Bad Request
< {
< "error_code": "BAD_REQUEST",
< "message": "Invalid path"
< }
```
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 16.34% 16.34%
=======================================
Files 98 98
Lines 13996 13996
=======================================
Hits 2287 2287
Misses 11518 11518
Partials 191 191 ☔ View full report in Codecov by Sentry. |
mgyucht
reviewed
Nov 27, 2023
Contributor
mgyucht
left a comment
mgyucht
left a comment
There was a problem hiding this comment.
Regenerating the SDK with this change does not change the generated code. The issue is that users can specify an initial / in this parameter, and it is documented as The absolute path of the file or directory in DBFS., where absolute paths begin with a /. However, if they do that, the path contains two consecutive /s.
nfx
changed the title
Contributor
|
Closing stale PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fundamentally prevent regressions like