Conversation
nfx
approved these changes
May 22, 2023
| // The new Databricks CLI is a single binary with size > 1MB. | ||
| // We use the size as a signal to determine which Databricks CLI is installed. | ||
| if stat.Size() < (1024 * 1024) { | ||
| return nil, errLegacyDatabricksCli |
Contributor
There was a problem hiding this comment.
This might not work on windows, but we'll fix after if integration tests fail
Merged
nfx
added a commit
that referenced
this pull request
May 22, 2023
* Added more usage examples for `go doc` and Go Packages ([#389](#389)). * Make OAuth work with new CLI ([#394](#394)). * Update from OpenAPI spec ([#390](#390)). Dependency updates: * Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 ([#393](#393)). * Bump google.golang.org/api from 0.122.0 to 0.123.0 ([#392](#392)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Acquire token by calling
databricksCLI. Incorporate detection to see if the path resolves to the Python CLI (< 0.100) or the new CLI (>= 0.100). This detection looks at the binary size to determine which one we're working with.Tests
make testpassingmake fmtapplied