Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
===========================================
- Coverage 34.57% 18.72% -15.86%
===========================================
Files 50 82 +32
Lines 3566 8551 +4985
===========================================
+ Hits 1233 1601 +368
- Misses 2220 6809 +4589
- Partials 113 141 +28
☔ View full report in Codecov by Sentry. |
Merged
nfx
added a commit
that referenced
this pull request
May 22, 2023
* Added more usage examples for `go doc` and Go Packages ([#389](#389)). * Make OAuth work with new CLI ([#394](#394)). * Update from OpenAPI spec ([#390](#390)). Dependency updates: * Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 ([#393](#393)). * Bump google.golang.org/api from 0.122.0 to 0.123.0 ([#392](#392)).
pietern
added a commit
that referenced
this pull request
May 24, 2023
## Changes Invalid refactor in #389. ## Tests Ran TestAccLibraries manually to confirm this fixes the issue.
pietern
added a commit
that referenced
this pull request
May 24, 2023
## Changes This was changed in #389 without testing. The function `w.Warehouses.DeleteByIdAndWait` always fails because upon deletion there is nothing left to GET and it returns a 404 error. For the sake of test cleanup, we can issue the delete and move on without waiting. ## Tests Ran TestAccSqlWarehouses manually to confirm this fixes the issue.
pietern
added a commit
that referenced
this pull request
May 24, 2023
## Changes Broken by #389. The test performs recursive listing and asserts the result is non-empty without first ensuring there is a file to list. This would sometimes pass and sometimes fail because tests are executed in parallel. ## Tests Ran TestAccWorkspaceRecursiveListNoTranspile manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse integration tests into specialized AST