Cleanup ephemeral groups in integration tests#368
Merged
Conversation
mgyucht
approved these changes
Apr 13, 2023
Contributor
mgyucht
left a comment
mgyucht
left a comment
There was a problem hiding this comment.
LGTM! Is this a good use of the defer keyword in golang?
Contributor
Author
|
@mgyucht It could be if tests didn't use Defer works if you return from a function under normal circumstances, not when unwinding a |
Contributor
Author
|
@mgyucht Turns out my understanding is wrong, defer should still work with |
Contributor
Author
|
@mgyucht The difference is that |
nfx
approved these changes
Apr 13, 2023
Merged
nfx
added a commit
that referenced
this pull request
Apr 20, 2023
# Version changelog ## 0.8.0 * Added more code generation utilities ([#369](#369)). * Body logger for non-JSON payload as well ([#365](#365)). * Cleanup ephemeral groups in integration tests ([#368](#368)). * Fixed external entity generation ([#372](#372)). * Skip loading default profile if host is already configured ([#363](#363)). * Update debug messages in config loader to display correct path ([#362](#362)). Dependency updates: * Bump golang.org/x/oauth2 from 0.6.0 to 0.7.0 ([#364](#364)). * Bump google.golang.org/api from 0.115.0 to 0.116.0 ([#361](#361)). * Bump google.golang.org/api from 0.116.0 to 0.118.0 ([#367](#367)). API changes: * Moved `clusterpolicies` APIs to `compute` package. * Moved `clusters` APIs to `compute` package. * Moved `commands` APIs to `compute` package. * Moved `globalinitscripts` APIs to `compute` package. * Moved `instancepools` APIs to `compute` package. * Moved `scim` APIs to `iam` package. * Moved `permissions` APIs to `iam` package. * Moved `ipaccesslists` APIs to `settings` package. * Moved `tokenmanagement` APIs to `settings` package. * Moved `tokens` APIs to `settings` package. * Moved `workspaceconf` APIs to `settings` package. * Moved `gitcredentials` APIs to `workspace` package. * Moved `repos` APIs to `workspace` package. * Moved `secrets` APIs to `workspace` package. * Split `unitcatalog` package to `catalog` and `sharing`. * Renamed `mlflow` package to `ml`. * Renamed `dbfs` package to `files`. * Renamed `deployment` package to `provisioning`. * Renamed `endpoints` package to `serving`. * Renamed `clusters.List` type to `compute.ListClustersRequest`. * Renamed `jobs.ListRuns` type to `jobs.ListRunsRequest`. * Renamed `jobs.ExportRun` type to `jobs.ExportRunRequest`. * Renamed `clusterpolicies.List` type to `compute.ListClusterPoliciesRequest`. * Renamed `jobs.List` type to `jobs.ListJobsRequest`. * Renamed `permissions.GetPermissionLevels` type to `iam.GetPermissionLevelsRequest`. * Renamed `pipelines.ListPipelineEvents` type to `pipelines.ListPipelineEventsRequest`. * Renamed `pipelines.ListPipelines` type to `pipelines.ListPipelinesRequest`. * Renamed `workspaceconf.GetStatus` type to `settings.GetStatusRequest`. * Renamed `repos.List` type to `workspace.ListReposRequest`. * Renamed `tokenmanagement.List` type to `settings.ListTokenManagementRequest`. * Renamed `workspace.Export` type to `workspace.ExportRequest`. * Renamed `workspace.List` type to `workspace.ListWorkspaceRequest`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
These tests left groups around that had to be removed manually/separately.
Tests
Manually ran changed integration tests.