Pass azure_client_id to Azure MSI if specified#354
Merged
nfx merged 10 commits intodatabricks:mainfrom Apr 3, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 41.30% 41.18% -0.13%
==========================================
Files 49 49
Lines 2736 2744 +8
==========================================
Hits 1130 1130
- Misses 1515 1523 +8
Partials 91 91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merged
nfx
added a commit
that referenced
this pull request
Apr 3, 2023
# Version changelog ## 0.6.0 * Added type to represent a loaded configuration file ([#349](#349)). * Added named `Wait` the level of services ([#348](#348)). * Pass `azure_client_id` to Azure MSI if specified ([#354](#354)). Dependency updates: * Bump google.golang.org/api from 0.112.0 to 0.114.0 ([#344](#344)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for providing client id for MSI use case with multiple MSIs attached to an azure vm.
Tests
Manually tested on a vm with multiple MSI.
Created failure first:
Same VM:
make testpassingmake fmtapplied