Skip to content

Adds named Wait the level of services#348

Merged
nfx merged 1 commit intomainfrom
methods/pos-args
Mar 28, 2023
Merged

Adds named Wait the level of services#348
nfx merged 1 commit intomainfrom
methods/pos-args

Conversation

@nfx
Copy link
Copy Markdown
Contributor

@nfx nfx commented Mar 28, 2023

Changes

  • Adds named Wait the level of services
  • Allow generating independent wait methods on the level of services
  • Waits are named as wait_<poll-method>_<service-singular>_<success-states>

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 29.16% and project coverage change: -0.11 ⚠️

Comparison is base (749bd92) 41.30% compared to head (a0ba9b6) 41.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   41.30%   41.20%   -0.11%     
==========================================
  Files          49       49              
  Lines        2709     2733      +24     
==========================================
+ Hits         1119     1126       +7     
- Misses       1499     1515      +16     
- Partials       91       92       +1     
Impacted Files Coverage Δ
openapi/code/service.go 46.57% <0.00%> (-5.34%) ⬇️
openapi/code/wait.go 53.94% <ø> (ø)
openapi/code/method.go 17.32% <77.77%> (+4.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nfx nfx merged commit c5aaa8a into main Mar 28, 2023
@nfx nfx deleted the methods/pos-args branch March 28, 2023 15:08
@nfx nfx mentioned this pull request Apr 3, 2023
nfx added a commit that referenced this pull request Apr 3, 2023
# Version changelog

## 0.6.0

* Added type to represent a loaded configuration file
([#349](#349)).
* Added named `Wait` the level of services
([#348](#348)).
* Pass `azure_client_id` to Azure MSI if specified
([#354](#354)).

Dependency updates:
 
* Bump google.golang.org/api from 0.112.0 to 0.114.0
([#344](#344)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants