fix[#285]: change APIError to use pointer receiver#298
Merged
nfx merged 1 commit intodatabricks:mainfrom Feb 3, 2023
Merged
Conversation
Allows APIError to be used as expected with `errors.As`
nfx
approved these changes
Feb 3, 2023
Codecov ReportBase: 40.84% // Head: 40.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 40.84% 40.87% +0.02%
==========================================
Files 46 46
Lines 2661 2662 +1
==========================================
+ Hits 1087 1088 +1
Misses 1485 1485
Partials 89 89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pietern
reviewed
Feb 3, 2023
| retry, err := apierr.CheckForRetry(ctx, response, err, responseBody.Bytes(), responseBodyErr) | ||
| if err != nil && !errors.As(err, &apierr.APIError{}) { | ||
| var apiErr *apierr.APIError | ||
| if err != nil && !errors.As(err, &apiErr) { |
Contributor
There was a problem hiding this comment.
This now takes a pointer to a pointer. I don't understand why this is necessary.
Contributor
There was a problem hiding this comment.
I'll take a look at the linked issue first.
Contributor
There was a problem hiding this comment.
I see the linked documentation that shows defining a pointer type prior to calling errors.As.
LGTM, thanks for the PR!
pietern
approved these changes
Feb 3, 2023
nfx
added a commit
that referenced
this pull request
Feb 17, 2023
* Change APIError to use pointer receiver ([#298](#298)). * Drop duplicate prefix in randomized email ([#299](#299)). * Expand semver pattern to be compliant with https://semver.org ([#302](#302)). * Fix `apierr.APIError` pointer receivers ([#307](#307)). * Skip loading config if auth is already explicitly configured directly ([#306](#306)). * Sync fixes for smallest node selection from Terraform ([#301](#301)). * Updated from OpenAPI spec ([#305](#305)). Dependency updates: * Bump google.golang.org/api from 0.109.0 to 0.110.0 ([#303](#303)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 17, 2023
* Change APIError to use pointer receiver ([#298](#298)). * Drop duplicate prefix in randomized email ([#299](#299)). * Expand semver pattern to be compliant with https://semver.org ([#302](#302)). * Fix `apierr.APIError` pointer receivers ([#307](#307)). * Skip loading config if auth is already explicitly configured directly ([#306](#306)). * Sync fixes for smallest node selection from Terraform ([#301](#301)). * Updated from OpenAPI spec ([#305](#305)). Dependency updates: * Bump google.golang.org/api from 0.109.0 to 0.110.0 ([#303](#303)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows APIError to be used as expected with
errors.As. Closes #285.