Skip to content

Add test for GetWorkspaceClient with SPOG host#1518

Merged
tanmay-db merged 1 commit intomainfrom
hectorcast-db/test-ws
Mar 5, 2026
Merged

Add test for GetWorkspaceClient with SPOG host#1518
tanmay-db merged 1 commit intomainfrom
hectorcast-db/test-ws

Conversation

@hectorcast-db
Copy link
Copy Markdown
Contributor

@hectorcast-db hectorcast-db commented Mar 5, 2026

Summary

Add test for GetWorkspaceClient with SPOG host to increase test coverage for new features.

How is this tested?

Run the new test.

NO_CHANGELOG=true

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1518
  • Commit SHA: 50d5620102125b6222b777d6665c526e2950feb6

Checks will be approved automatically on success.

@tanmay-db tanmay-db enabled auto-merge March 5, 2026 13:32
@tanmay-db tanmay-db added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit e996b46 Mar 5, 2026
15 of 16 checks passed
@tanmay-db tanmay-db deleted the hectorcast-db/test-ws branch March 5, 2026 13:46
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2026
<!--
  This template provides a recommended structure for PR descriptions.
  Adapt it freely — the goal is clarity, not rigid compliance.
The three-section format (Summary / Why / What Changed) helps reviewers
understand the change quickly and makes the PR easier to revisit later.
-->

## Summary
Adding an entry in NEXT_CHANGELOG.md for recent merged changes:
* Fix `GetWorkspaceClient` for unified account hosts
([#1517](#1517)).
* Add test for `GetWorkspaceClient` with SPOG host
([#1518](#1518)).
<!--
One or two sentences describing what this PR changes and what it
enables.
  Focus on the effect, not the implementation details.

  Example:
    Extracts the credentials chain iteration logic into a reusable
    `NewCredentialsChain` constructor so that internal tools can compose
their own authentication chains from individual credential strategies.
-->

## Why
Tagging workflow doesn't trigger a release if NEXT_CHANGELOG.md is empty
<!--
Explain the problem that motivated this change. A reviewer who reads
only
this section should understand why the PR exists and what problem it
solves.

- Start with the status quo: how things work today and what limitation
exists.
- Explain who is affected and what they cannot do (or must work around).
  - If alternatives were considered and rejected, briefly mention why.
  - End with how this PR addresses the gap.

  The "why" is the most important part of a PR description — it usually
  cannot be inferred from the code itself.
-->

## What changed

### Interface changes

<!--
New or modified public API surface: types, functions, configuration
options.
Use backticks for code references. Write "None." if there are no
changes.

  Example:
- **`NewCredentialsChain(...CredentialsStrategy) CredentialsStrategy`**
—
Takes an ordered list of credential strategies and returns a strategy
      that tries them in sequence.
-->

### Behavioral changes

<!--
User-visible behavior changes: different defaults, changed error
messages,
new side effects, performance characteristics. Write "None." if this is
a
  pure refactor — this explicitly reassures reviewers.
-->

### Internal changes

<!--
  Refactoring, file moves, implementation details, test infrastructure.
  Things that don't affect the public API or user-visible behavior.
-->

## How is this tested?

<!--
Describe any tests you have done, especially tests that are not part of
the unit tests (e.g. local tests, integration tests, manual
verification).

ALWAYS ANSWER THIS QUESTION: answer with "N/A" if tests are not
applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about
what
has been done and not done provides important context to the reviewers.
-->

N/A
deco-sdk-tagging bot added a commit that referenced this pull request Mar 5, 2026
## Release v0.118.0

### Internal Changes

* Fix `GetWorkspaceClient` for unified account hosts ([#1517](#1517)).
* Add test for `GetWorkspaceClient` with SPOG host ([#1518](#1518)).
github-merge-queue bot pushed a commit to databricks/cli that referenced this pull request Mar 10, 2026
## Changes

- Bump `github.com/databricks/databricks-sdk-go` from v0.117.0 to
v0.119.0
- Update OpenAPI SHA
- Regenerate CLI code via `make generate`

<details><summary>SDK v0.117 -> v0.119.0 changelog</summary>
<p>

## Release v0.119.0 (2026-03-09)

### API Changes
* Add
[dataclassification](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dataclassification)
and
[knowledgeassistants](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/knowledgeassistants)
packages.
* Add
[w.DataClassification](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dataclassification#DataClassificationAPI)
workspace-level service.
* Add
[w.KnowledgeAssistants](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/knowledgeassistants#KnowledgeAssistantsAPI)
workspace-level service.
* Add `GenieCreateEvalRun`, `GenieGetEvalResultDetails`,
`GenieGetEvalRun`, `GenieListEvalResults` and `GenieListEvalRuns`
methods for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service.
* Add `TelemetryExportDestinations` field for
[apps.App](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#App).


## Release v0.118.0 (2026-03-05)

### Internal Changes

* Fix `GetWorkspaceClient` for unified account hosts
([#1517](databricks/databricks-sdk-go#1517)).
* Add test for `GetWorkspaceClient` with SPOG host
([#1518](databricks/databricks-sdk-go#1518)).

</p>
</details>

## Tests

- [x] `make lintfull`
- [x] go test ./internal/build ./bundle/internal/schema
./bundle/direct/dresources ./bundle/config/resources
- [x] `make checks`
rauchy pushed a commit to databricks/cli that referenced this pull request Mar 17, 2026
## Changes

- Bump `github.com/databricks/databricks-sdk-go` from v0.117.0 to
v0.119.0
- Update OpenAPI SHA
- Regenerate CLI code via `make generate`

<details><summary>SDK v0.117 -> v0.119.0 changelog</summary>
<p>

## Release v0.119.0 (2026-03-09)

### API Changes
* Add
[dataclassification](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dataclassification)
and
[knowledgeassistants](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/knowledgeassistants)
packages.
* Add
[w.DataClassification](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dataclassification#DataClassificationAPI)
workspace-level service.
* Add
[w.KnowledgeAssistants](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/knowledgeassistants#KnowledgeAssistantsAPI)
workspace-level service.
* Add `GenieCreateEvalRun`, `GenieGetEvalResultDetails`,
`GenieGetEvalRun`, `GenieListEvalResults` and `GenieListEvalRuns`
methods for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service.
* Add `TelemetryExportDestinations` field for
[apps.App](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#App).


## Release v0.118.0 (2026-03-05)

### Internal Changes

* Fix `GetWorkspaceClient` for unified account hosts
([#1517](databricks/databricks-sdk-go#1517)).
* Add test for `GetWorkspaceClient` with SPOG host
([#1518](databricks/databricks-sdk-go#1518)).

</p>
</details>

## Tests

- [x] `make lintfull`
- [x] go test ./internal/build ./bundle/internal/schema
./bundle/direct/dresources ./bundle/config/resources
- [x] `make checks`
github-merge-queue bot pushed a commit to databricks/databricks-sdk-java that referenced this pull request Mar 23, 2026
## 🥞 Stacked PR
Use this
[link](https://github.com/databricks/databricks-sdk-java/pull/712/files)
to review incremental changes.
-
[**hectorcast-db/stack/port-3-test-get-workspace-client-spog**](#712)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/712/files)]
-
[hectorcast-db/stack/port-4-resolve-metadata-on-init](#713)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/713/files/12f05320deaf1e2d96229e7bb280ecf7c59b25ce..f5a4892cb3877c74bd8cff5979a3a2d177d304ff)]
-
[hectorcast-db/stack/port-5-token-audience-from-metadata](#714)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/714/files/f5a4892cb3877c74bd8cff5979a3a2d177d304ff..513d3f937652fe2a92564fddbb50a46b0527cf97)]
-
[hectorcast-db/stack/port-6-gcp-sa-nonblocking](#718)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/718/files/513d3f937652fe2a92564fddbb50a46b0527cf97..560f2173f1ac8880634d9ad874a72824903a91e9)]
-
[hectorcast-db/stack/port-7-integration-test-metadata](#719)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/719/files/560f2173f1ac8880634d9ad874a72824903a91e9..f79a3e876905d11de94c5f8c589b2af702397cd3)]
-
[hectorcast-db/stack/port-8-remove-unified-flag](#720)
[[Files
changed](https://github.com/databricks/databricks-sdk-java/pull/720/files/f79a3e876905d11de94c5f8c589b2af702397cd3..3c63fc8995cba2381947a52f485bef2cb17693a3)]

---------
## Summary

Port of Go SDK
[#1518](databricks/databricks-sdk-go#1518).

Adds test for `getWorkspaceClient()` with SPOG host to verify that the
config is cloned (not mutated) and multiple calls produce independent
WorkspaceClients.

**Test:** `testGetWorkspaceClientForSpogHostDoesNotMutateAccountConfig`
— creates two workspace clients from the same AccountClient, verifies
each has its own workspaceId and the account config is unchanged.

`NO_CHANGELOG=true`

## Test plan
- [x] `AccountClientTest`: 4 tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants