[Fix] Support for Spark versions with multiple Scala versions#1345
Merged
[Fix] Support for Spark versions with multiple Scala versions#1345
Conversation
This is a fix for databricks/terraform-provider-databricks#5218. The issue is cased by the fact that `Scala` selector had default value of `2.12` (for Terraform only), and as result was filtering out 17.x versions that are released only with Scala 2.13. Fix is to relax the default value, but handle the case when there could be 2.12 and 2.13 versions for the same DBR version (16.x only). Also bumped staticcheck to 0.6.1 to support compilation with Go 1.25 Signed-off-by: Alex Ott <[email protected]>
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This is a fix for databricks/terraform-provider-databricks#5218. The issue is cased by the fact that
Scalaselector had default value of2.12(for Terraform only), and as result was filtering out 17.x versions that are released only with Scala 2.13.Fix is to relax the default value, but handle the case when there could be 2.12 and 2.13 versions for the same DBR version (16.x only).
Removed all Terraform customizations from the Go SDK struct, will be handled separately in Terraform itself
Also bumped staticcheck to 0.6.1 to support compilation with Go 1.25
How is this tested?
Added unit test, tested manually