Skip to content

[Internal] Add workflows manage integration tests checks#1032

Merged
hectorcast-db merged 3 commits intomainfrom
enable-check
Sep 2, 2024
Merged

[Internal] Add workflows manage integration tests checks#1032
hectorcast-db merged 3 commits intomainfrom
enable-check

Conversation

@hectorcast-db
Copy link
Copy Markdown
Contributor

@hectorcast-db hectorcast-db commented Aug 30, 2024 •
edited
Loading

Changes

Add workflows manage integration tests checks.

Tests

Appended the following code to the integration-tests.yml to simulate tests running


    # Step to Wait 10 seconds
    - name: Wait 10 seconds
      run: sleep 10

    - name: Trigger another workflow
      env:
        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        gh workflow run check-mark.yml --repo databricks/databricks-sdk-go --ref enable-check \
        -f pull_request_number=${{ github.event.pull_request.number }} \
        -f check_run_id=${{ env.CHECK_RUN_ID }} \
        -f test_run_id="potato" \
        -f status="running"
     
    # Step to Wait 10 seconds
    - name: Wait 10 seconds
      run: sleep 10

    - name: Trigger another workflow
      env:
        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        gh workflow run check-mark.yml --repo databricks/databricks-sdk-go --ref enable-check \
        -f pull_request_number=${{ github.event.pull_request.number }} \
        -f check_run_id=${{ env.CHECK_RUN_ID }} \
        -f test_run_id="potato" \
        -f status="failed"

    # Step to Wait 10 seconds
    - name: Wait 10 seconds
      run: sleep 10

    - name: Trigger another workflow
      env:
        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        gh workflow run check-mark.yml --repo databricks/databricks-sdk-go --ref enable-check \
        -f pull_request_number=${{ github.event.pull_request.number }} \
        -f check_run_id=${{ env.CHECK_RUN_ID }} \
        -f test_run_id="potato" \
        -f status="completed"

Result:
Screenshot 2024-09-02 at 11 01 32

https://github.com/databricks/databricks-sdk-go/runs/29554526479

NOTE: Run integration tests link not tested since the workflow does not exist yet.

@hectorcast-db hectorcast-db force-pushed the enable-check branch 17 times, most recently from a51678d to 2caf9dd Compare August 30, 2024 12:16
@hectorcast-db hectorcast-db force-pushed the enable-check branch 6 times, most recently from 98df414 to 603021a Compare September 2, 2024 08:35
@hectorcast-db hectorcast-db force-pushed the enable-check branch 4 times, most recently from 7149670 to a2df174 Compare September 2, 2024 08:58
@hectorcast-db
Copy link
Copy Markdown
Contributor Author

hectorcast-db commented Sep 2, 2024

Screenshot 2024-09-02 at 11 01 32

@hectorcast-db hectorcast-db changed the title [TEST] Enforce integration tests [Internal] Add workflows manage integration tests checks Sep 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2024

A new approval check has been created. Start integration tests by using the following link.

https://github.com/databricks-eng/eng-dev-ecosystem/actions/workflows/sdk-go-isolated-pr.yml/dispatch?pull_request_number=1032&check_run_id=29556586296

This check will be approved automatically on success.

Check URL: https://github.com/databricks/databricks-sdk-go/runs/29556586296

@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 6ab81ee Sep 2, 2024
@hectorcast-db hectorcast-db deleted the enable-check branch September 2, 2024 10:50
mgyucht added a commit that referenced this pull request Sep 4, 2024
@mgyucht
[Release] Release v0.46.0
7ebe419 
### Bug Fixes

 * Fail fast when authenticating if host is not configured ([#1033](#1033)).
 * Improve non-JSON error handling ([#1031](#1031)).

### Internal Changes

 * Add TestAccCreateOboTokenOnAws to flaky test list ([#1029](#1029)).
 * Add workflows manage integration tests checks ([#1032](#1032)).
 * Fix TestMwsAccWorkspaces cleanup ([#1028](#1028)).
 * Improve integration test comment ([#1035](#1035)).
 * Temporary ignore Metastore test failures ([#1027](#1027)).
 * Update test to support new accounts ([#1026](#1026)).
 * Use statuses instead of checks ([#1036](#1036)).

### API Changes:

 * Added `RegenerateDashboard` method for [w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI) workspace-level service.
 * Added [catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest) and [catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
 * Added [jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails), [jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode), [jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State), [jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus), [jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode), [jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails) and [jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
 * Added `Status` field for [jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
 * Added `Status` field for [jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
 * Added `Status` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
 * Added `Status` field for [jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
 * Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
 * Added `ColumnsToSync` field for [vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
 * Changed `WorkloadSize` field for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput) to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
@mgyucht mgyucht mentioned this pull request Sep 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
@mgyucht
[Release] Release v0.46.0 (#1037)
37cb031 
### Bug Fixes

* Fail fast when authenticating if host is not configured
([#1033](#1033)).
* Improve non-JSON error handling
([#1031](#1031)).


### Internal Changes

* Add TestAccCreateOboTokenOnAws to flaky test list
([#1029](#1029)).
* Add workflows manage integration tests checks
([#1032](#1032)).
* Fix TestMwsAccWorkspaces cleanup
([#1028](#1028)).
* Improve integration test comment
([#1035](#1035)).
* Temporary ignore Metastore test failures
([#1027](#1027)).
* Update test to support new accounts
([#1026](#1026)).
* Use statuses instead of checks
([#1036](#1036)).


### API Changes:

* Added `RegenerateDashboard` method for
[w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI)
workspace-level service.
* Added
[catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest)
and
[catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
* Added
[jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails),
[jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode),
[jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State),
[jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus),
[jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode),
[jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails)
and
[jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
* Added `Status` field for
[jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `Status` field for
[jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
* Added `Status` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `Status` field for
[jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
* Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields
for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
* Added `ColumnsToSync` field for
[vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
* Changed `WorkloadSize` field for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput)
to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthban-db parthban-db parthban-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hectorcast-db @parthban-db