Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: databricks/databricks-sdk-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.49.0
Choose a base ref
...
head repository: databricks/databricks-sdk-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.50.0
Choose a head ref
  • 6 commits
  • 54 files changed
  • 3 contributors

Commits on Oct 22, 2024

  1. [Internal] Automatically trigger integration tests (#1067) 

    ## Changes
Automatically trigger integration tests when a PR is opened or updated

## Tests
Updated workflow triggered the tests. On success, the tests marked the
check as succesfull.

- [ ] `make test` passing
- [ ] `make fmt` applied
- [ ] relevant integration tests applied
    @hectorcast-db
    hectorcast-db authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    dac9a9e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. [Internal] Add test instructions for external contributors (#1073) 

    ## Changes

Add test instructions for external contributions. The instructions are
meant for Databricks reviewers who will be running the integration
tests.

## Tests
Temporary added the following target to trigger the workflow
```
pull_request:
    types: [opened, reopened, synchronize]
```
and changed the equality in the external check
```
          if [ "${{ github.event.pull_request.head.repo.full_name }}" == "${{ github.repository }}" ]; then
```

Result:
![Screenshot 2024-10-29 at 10 54
05](https://github.com/user-attachments/assets/a6bade55-e4ce-4aed-bbee-1249def2ab5f)
    @hectorcast-db
    hectorcast-db authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fdd6b16 View commit details
    Browse the repository at this point in the history

  2. [Internal] Remove unnecessary test (#1071) 

    ## Changes
Remove unnecessary tests. The tests are integration tests for the
API/service, not the SDK itself.
The removed tests take >20 minutes each and they are flaky.

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [X] `make test` passing
- [X] `make fmt` applied
- [X] relevant integration tests applied
    @hectorcast-db
    hectorcast-db authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ec962ec View commit details
    Browse the repository at this point in the history

  3. [Internal] Add DCO guidelines (#1047) 

    ## Changes

This PR updates the contributing guidelines to include the DCO
(Developer Certificate of Origin) that external contributors must
sign-off to contribute.

## Tests

N/A
    @renaudhartert-db
    renaudhartert-db authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e873ca2 View commit details
    Browse the repository at this point in the history

  4. [Internal] Move templates in the code generator (#1075) 

    ## Changes
<!-- Summary of your changes that are easy to understand -->
Move templates in the code generator.

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->
The generator is working correctly with the new configuration.
    @parthban-db
    parthban-db authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e338159 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. [Release] Release v0.50.0 (#1077) 

    ### Internal Changes

* Add DCO guidelines
([#1047](#1047)).
* Add test instructions for external contributors
([#1073](#1073)).
* Automatically trigger integration tests
([#1067](#1067)).
* Move templates in the code generator
([#1075](#1075)).
* Remove unnecessary test
([#1071](#1071)).


### API Changes:

* Added
[w.AibiDashboardEmbeddingAccessPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingAccessPolicyAPI)
workspace-level service and
[w.AibiDashboardEmbeddingApprovedDomains](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AibiDashboardEmbeddingApprovedDomainsAPI)
workspace-level service.
* Added `AppDeployment` field for
[apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
* Added `App` field for
[apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Added `App` field for
[apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
* Added `Table` field for
[catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
* Added `Dashboard` field for
[dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
* Added `Schedule` field for
[dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
* Added `Subscription` field for
[dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
* Added `Dashboard` field for
[dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
* Added `Schedule` field for
[dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).
* Added `PageToken` field for
[oauth2.ListServicePrincipalSecretsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsRequest).
* Added `NextPageToken` field for
[oauth2.ListServicePrincipalSecretsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ListServicePrincipalSecretsResponse).
* Added `IsNoPublicIpEnabled` field for
[provisioning.CreateWorkspaceRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#CreateWorkspaceRequest).
* Added `ExternalCustomerInfo` and `IsNoPublicIpEnabled` fields for
[provisioning.Workspace](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#Workspace).
* Added `LastUsedDay` field for
[settings.TokenInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#TokenInfo).
* Changed `Create` method for
[w.Apps](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#AppsAPI)
workspace-level service with new required argument order.
* Changed `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service . New request type is
[dashboards.GenieExecuteMessageQueryRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieExecuteMessageQueryRequest).
* Changed `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service to type `ExecuteMessageQuery` method for
[w.Genie](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI)
workspace-level service.
* Changed `Create`, `CreateSchedule`, `CreateSubscription` and
`UpdateSchedule` methods for
[w.Lakeview](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewAPI)
workspace-level service with new required argument order.
* Removed `PrevPageToken` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).

The following fields are now nested in the request:

* Removed `DeploymentId`, `Mode` and `SourceCodePath` fields for
[apps.CreateAppDeploymentRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppDeploymentRequest).
* Removed `Description`, `Name` and `Resources` fields for
[apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Removed `Description` and `Resources` fields for
[apps.UpdateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#UpdateAppRequest).
* Removed `Name` and `Spec` fields for
[catalog.CreateOnlineTableRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateOnlineTableRequest).
* Removed `DisplayName`, `ParentPath`, `SerializedDashboard` and
`WarehouseId` fields for
[dashboards.CreateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateDashboardRequest).
* Removed `CronSchedule`, `DisplayName` and `PauseStatus` fields for
[dashboards.CreateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateScheduleRequest).
* Removed `Subscriber` field for
[dashboards.CreateSubscriptionRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#CreateSubscriptionRequest).
* Removed `DisplayName`, `Etag`, `SerializedDashboard` and `WarehouseId`
fields for
[dashboards.UpdateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateDashboardRequest).
* Removed `CronSchedule`, `DisplayName`, `Etag` and `PauseStatus` fields
for
[dashboards.UpdateScheduleRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UpdateScheduleRequest).

OpenAPI SHA: 25b2478e5a18c888f0d423249abde5499dc58424, Date: 2024-10-31
    @renaudhartert-db
    renaudhartert-db authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e9314bd View commit details
    Browse the repository at this point in the history
Loading