Comparing changes

## Changes Parsing error messages from the `/api/2.0/preview/scim/v2/Me` API causes parsing errors because the API returns the HTTP status (i.e. an `int`) as error code instead of a `string`. For example: ```json { "error_code": 403, "message": "Invalid access token." } ``` This PR solves the problem by parsing the `error_code` field as a `string` no matter its type. Note that the implementation is overkill because it also converts _any_ literal to a string (e.g. `true` becomes `"true"`). We could guarantee that the behavior is limited to converting `int` to `string` by adding a custom [Unmarshaler](https://pkg.go.dev/encoding/json#Unmarshaler) but this didn't seem worth the additional code. This PR also: - Refactors the code by removing the `APIErroBody` struct. The rationale is that the struct exists solely for parsing and is actually not used outside of the `parseErrorFromResponse` function. Turning it into an anonymous struct within `parseErrorFromResponse` makes the intent crystal clear. - Slightly restructures the test cases to better match go's naming conventions and separate the "three tests parts" (init, test, assert). ## Tests Added a unit test to verify that (i) an int error code are parsed as string, and (ii) that this string is properly ignored. - [x] `make test` passing - [x] `make fmt` applied - [x] relevant integration tests applied

_Note: this PR is a copy of PR #950 which could not be merged because of some unverified commits. Please check PR #950 for the original review and comments._ ## Changes This PR adds a `CredentialsProvider` to authenticate with Azure from Github workflows. The code is inspired by a similar feature already implemented in the Python SDK. It works as follows: 1. Obtain an ID token from Azure leveraging the env variables `ACTIONS_ID_TOKEN_REQUEST_URL` and `ACTIONS_ID_TOKEN_REQUEST_TOKEN` as [explained here](https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers). 2. Exchange that ID token for an auth token. ## Tests Added a test suite which covers all the added code paths. I've also confirmed in my own Github Action that the code is properly able to authenticate. Note: I'm not super happy with how errors are compared (i.e. using a prefix) which is a little brittle. A better approach would be to leverage `errors.As` or `errors.Is`. However, it is difficult to do that at the moment without adding ad hoc new error types. A longer term solution would probably involve standardizing the package around a set of clearly defined error types shared by all implementations of `CredentialsProvider` in `config`. That is out of the scope of this PR though. - [x] `make test` passing - [x] `make fmt` applied - [x] relevant integration tests applied

## Changes Add DataPlane API Support ## Tests Manual test: ``` input := []string{} input = append(input, "Hello, I'm a language model,") _, err := w.ServingEndpointsDataPlane.Query(context.Background(), serving.QueryEndpointInput{ Name: <...>, Inputs: input, }) require.NoError(t, err) ``` - [x] `make test` passing - [x] `make fmt` applied - [ ] relevant integration tests applied

## Changes Add ChangelogConfig to Generator struct ## Tests - [X] `make test` passing - [X] `make fmt` applied - [ ] relevant integration tests applied

These are necessary to handle a problem with timeouts in permissions fetching ## Changes  ## Tests  - [x] `make test` passing - [x] `make fmt` applied - [ ] relevant integration tests applied Signed-off-by: Alex Ott <[email protected]>

## 0.43.1 ### Major Changes and Improvements: * Add a credentials provider for Github Azure OIDC ([#965](#965)). * Add DataPlane API Support ([#936](#936)). * Added more error messages for retriable errors (timeouts, etc.) ([#963](#963)). ### Internal Changes * Add ChangelogConfig to Generator struct ([#967](#967)). * Improve Changelog by grouping changes ([#962](#962)). * Parse API Error messages with `int` error codes ([#960](#960)).

## Changes Enforce Tag on PRs ## Tests - [ ] `make test` passing - [ ] `make fmt` applied - [ ] relevant integration tests applied - [X] New check as part of the PR

## Changes  Generate the errors on which we should retry ## Tests  - [ ] `make test` passing - [ ] `make fmt` applied - [ ] relevant integration tests applied

## Changes Add release tag ## Tests  - [ ] `make test` passing - [ ] `make fmt` applied - [ ] relevant integration tests applied

## 0.43.2 ### Internal Changes * Enforce Tag on PRs ([#969](#969)). * Generate SDK for `apierr` changes ([#970](#970)). * Add Release tag and Workflow Fix ([#972](#972)).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comparing changes

Open a pull request

Commits on Jul 3, 2024

Commits on Jul 5, 2024

Commits on Jul 8, 2024

Commits on Jul 9, 2024

This comparison is taking too long to generate.

Uh oh!