Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: databricks/databricks-sdk-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.36.0
Choose a base ref
...
head repository: databricks/databricks-sdk-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.37.0
Choose a head ref
  • 3 commits
  • 30 files changed
  • 2 contributors

Commits on Mar 26, 2024

  1. Fix integration test naming for UC Files (#868) 

    ## Changes
These tests are currently being skipped in integration tests. They run
in the non-UC runner because the test name starts with TestAcc, but they
are skipped there because metastore ID is not defined:

```
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCUploadAndDownloadFilesAPI: === RUN   TestAccUCUploadAndDownloadFilesAPI
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCUploadAndDownloadFilesAPI (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCDeleteFile: === RUN   TestAccUCDeleteFile
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCDeleteFile (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCGetMetadata: === RUN   TestAccUCGetMetadata
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCGetMetadata (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCCreateDirectory: === RUN   TestAccUCCreateDirectory
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCCreateDirectory (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCListDirectoryContents: === RUN   TestAccUCListDirectoryContents
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCListDirectoryContents (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCDeleteDirectory: === RUN   TestAccUCDeleteDirectory
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCDeleteDirectory (0.00s)
2024/03/26 02:08:32 [INFO] 🦥 TestAccUCGetDirectoryMetadata: === RUN   TestAccUCGetDirectoryMetadata
    init_test.go:103: Environment variable TEST_METASTORE_ID is missing
--- SKIP: TestAccUCGetDirectoryMetadata (0.00s)
```

This PR renames these tests so they are run in UC testing environments.

## Tests
- [x] Triggered the integration tests on this PR.
    @mgyucht
    mgyucht authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5eaf7d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Properly escape multi-segment path parameters (#869) 

    ## Changes
Currently, path parameters are directly interpolated into the request
URL without escaping. This means that characters like `/`, `?` and `#`
will not be percent-encoded and will affect the semantics of the URL,
starting a new path segment, query parameters, or fragment,
respectively. This means that it is impossible for users of the Files
API to upload/download objects that contain `?` or `#` in their name.
`/` is allowed in the path of the Files API, so it does not need to be
escaped.

The Files API is currently marked with `x-databricks-multi-segment`,
indicating that it should be permitted to have `/` characters but other
characters need to be percent-encoded. This PR implements this.

This PR builds on #868, correcting the test names for UC files.

## Tests
- [x] Unit test for multi-segment path escaping behavior.
- [x] Updated integration test to use `#` and `?` symbols in the file
name. This failed on `main` but succeeded on this PR.
    @mgyucht
    mgyucht authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bfdcd43 View commit details
    Browse the repository at this point in the history

  2. Release 0.37.0 (#870) 

    ### Internal changes

* Fix integration test naming for UC Files
([#868](#868)).

### API Changes

* Added `Migrate` and `Unpublish` methods for
[w.Lakeview](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewAPI)
workspace-level service.
* Added
[dashboards.MigrateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#MigrateDashboardRequest).
* Added
[dashboards.UnpublishDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#UnpublishDashboardRequest).
* Added `Description`, `QueueDuration` and `RepairHistory` fields for
[jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `ComputeKey` and `JobClusterKey` fields for
[jobs.ClusterSpec](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ClusterSpec).
* Changed `Left`, `Op` and `Right` fields for
[jobs.ConditionTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ConditionTask)
to be required.
* Changed `EditMode` field for
[jobs.CreateJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob)
to
[jobs.JobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobEditMode).
* Replaced
[jobs.CreateJobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJobEditMode)
to
[jobs.JobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobEditMode).
* Changed `Url` field for
[jobs.FileArrivalTriggerConfiguration](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#FileArrivalTriggerConfiguration)
to be required.
* Changed `ErrorMessageStats` field for
[jobs.ForEachStats](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ForEachStats)
to
[jobs.ForEachTaskErrorMessageStatsList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ForEachTaskErrorMessageStatsList).
* Changed `NewCluster` field for
[jobs.JobCluster](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobCluster)
to be required.
* Changed `EditMode` field for
[jobs.JobSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings)
to
[jobs.JobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobEditMode).
* Replaced
[jobs.JobSettingsEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettingsEditMode)
by
[jobs.JobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobEditMode).
* Changed `Metric`, `Op` and `Value` fields for
[jobs.JobsHealthRule](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobsHealthRule)
to be required.
* Changed `RunType` field for
[jobs.ListRunsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ListRunsRequest)
to
[jobs.RunType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunType).
* Removed
[jobs.ListRunsRunType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ListRunsRunType).
* Removed
[jobs.ParamPairs](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ParamPairs).
* Changed `PipelineId` field for
[jobs.PipelineTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#PipelineTask)
to be required.
* Changed `EntryPoint` and `PackageName` fields for
[jobs.PythonWheelTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#PythonWheelTask)
to be required.
* Changed `JobParameters` field for
[jobs.RepairRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairRun)
to map[string]`string`.
* Changed `BaseParameters` field for
[jobs.ResolvedNotebookTaskValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedNotebookTaskValues)
to map[string]`string`.
* Changed `Parameters` field for
[jobs.ResolvedParamPairValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedParamPairValues)
to map[string]`string`.
* Changed `NamedParameters` field for
[jobs.ResolvedPythonWheelTaskValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedPythonWheelTaskValues)
to map[string]`string`.
* Removed `NamedParameters` field for
[jobs.ResolvedRunJobTaskValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedRunJobTaskValues).
* Changed `Parameters` field for
[jobs.ResolvedRunJobTaskValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedRunJobTaskValues)
to map[string]`string`.
* Added `JobParameters` field for
[jobs.ResolvedRunJobTaskValues](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ResolvedRunJobTaskValues).
* Added `Description` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `QueueDuration` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Changed `Op` field for
[jobs.RunConditionTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunConditionTask)
to
[jobs.ConditionTaskOp](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#ConditionTaskOp).
* Removed
[jobs.RunConditionTaskOp](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunConditionTaskOp).
* Changed `Inputs` and `Task` fields for
[jobs.RunForEachTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunForEachTask)
to be required.
* Changed `JobParameters` field for
[jobs.RunJobTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunJobTask)
to map[string]`string`.
* Added `DbtCommands`, `JarParams`, `NotebookParams`, `PipelineParams`,
`PythonNamedParams`, `PythonParams`, `SparkSubmitParams` and `SqlParams`
fields for
[jobs.RunJobTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunJobTask).
* Changed `JobParameters` field for
[jobs.RunNow](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunNow)
to map[string]`string`.
* Added `Info` field for
[jobs.RunOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunOutput).
* Removed `JobParameters` field for
[jobs.RunParameters](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunParameters).
* Changed `TaskKey` field for
[jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask)
to be required.
* Added `ComputeKey`,`EmailNotifications`, `JobClusterKey`,
`NotificatioSettings`, `RunDuration`, `RunPageUrl`, `TimeoutSeconds` and
`WebhookNotifications` fields for
[jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
* Added `EndpointId` field for
[jobs.SqlQueryOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#SqlQueryOutput).
* Added `ConditionTask` field for
[jobs.SubmitRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#SubmitRun).
* Added `DbtCommands`, `JarParams`, `NotebookParams`, `PipelineParams`,
`PythonNamedParams`, `PythonParams`, `SparkSubmitParams` and `SqlParams`
field for
[jobs.SubmitRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#SubmitRun).
* Added `Description` field for
[jobs.SubmitTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#SubmitTask).
* Added `DisableAutoOptimization` field for
[jobs.Task](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Task).
* Added `NoAlertForSkippedRuns` field for
[jobs.TaskEmailNotifications](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TaskEmailNotifications).
* Added `TableUpdate` field for
[jobs.TriggerSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TriggerSettings).
* Changed `Id` field for
[jobs.Webhook](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Webhook)
to be required.
* Changed `OnDurationWarningThresholdExceeded` field for
[jobs.WebhookNotifications](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#WebhookNotifications)
to
[jobs.WebhookList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#WebhookList).
* Removed
[jobs.WebhookNotificationsOnDurationWarningThresholdExceededItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#WebhookNotificationsOnDurationWarningThresholdExceededItem).
* Added
[jobs.JobEditMode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobEditMode).
* Removed
[serving.AwsBedrockConfig](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AwsBedrockConfig).
* Removed
[serving.AwsBedrockConfigBedrockProvider](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AwsBedrockConfigBedrockProvider).
* Removed `AwsBedrockConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added `AmazonBedrockConfig` field for
[serving.ExternalModel](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalModel).
* Added
[serving.AmazonBedrockConfig](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AmazonBedrockConfig).
* Added
[serving.AmazonBedrockConfigBedrockProvider](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AmazonBedrockConfigBedrockProvider).
* Changed `Get` method for
[w.IpAccessLists](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#IpAccessListsAPI)
workspace-level service . New request type is
[settings.GetIpAccessListRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListRequest).
* Renamed
[settings.GetIpAccessList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessList)
to
[settings.GetIpAccessListRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListRequest).

OpenAPI SHA: d38528c3e47dd81c9bdbd918272a3e49d36e09ce, Date: 2024-03-27
    @hectorcast-db
    hectorcast-db authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2877f5d View commit details
    Browse the repository at this point in the history
Loading