Use interactive prompt to select resource to run if not specified#762
Merged
Use interactive prompt to select resource to run if not specified#762
Conversation
pietern
requested review from
andrewnester,
lennartkats-db and
shreyas-goenka
Contributor
|
@pietern Nice! Could you include a screenshot? |
Contributor
Author
|
Same prompter as we use for other commands: |
Contributor
|
Love it! |
Contributor
|
Niice! @pietern shouldn't the base question UI that is used here actually show the prompt before the search box?
instead of
|
Contributor
Author
|
@lennartkats-db The prompting library doesn't support switching it around. If we end up replacing it at some point we could fix that. |
Contributor
|
Ok. I wonder if that could be worked around by printing the prompt ourselves and leaving the prompt passed to the library empty? In any case, certainly not blocking for this work. |
andrewnester
approved these changes
Sep 11, 2023
Contributor
Author
|
@lennartkats-db The prompt library removes that prompt label from the output once selected, which is nice. If we print this to stderr ourselves we wouldn't (without doing ANSI magic ourselves). |
lennartkats-db
added a commit
that referenced
this pull request
Sep 12, 2023
pietern
added a commit
that referenced
this pull request
Sep 12, 2023
This release marks the public preview phase of Databricks Asset Bundles. For more information, please refer to our online documentation at https://docs.databricks.com/en/dev-tools/bundles/. CLI: * Prompt once for a client profile ([#727](#727)). Bundles: * Use clearer error message when no interpolation value is found. ([#764](#764)). * Use interactive prompt to select resource to run if not specified ([#762](#762)). * Add documentation link bundle command group description ([#770](#770)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
This release marks the public preview phase of Databricks Asset Bundles. For more information, please refer to our online documentation at https://docs.databricks.com/en/dev-tools/bundles/. CLI: * Prompt once for a client profile ([#727](#727)). Bundles: * Use clearer error message when no interpolation value is found. ([#764](#764)). * Use interactive prompt to select resource to run if not specified ([#762](#762)). * Add documentation link bundle command group description ([#770](#770)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Changes Display an interactive prompt with a list of resources to run if one isn't specified and the command is run interactively. ## Tests Manually confirmed: * The new prompt works * Shell completion still works * Specifying a key argument still works
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
This release marks the public preview phase of Databricks Asset Bundles. For more information, please refer to our online documentation at https://docs.databricks.com/en/dev-tools/bundles/. CLI: * Prompt once for a client profile ([#727](#727)). Bundles: * Use clearer error message when no interpolation value is found. ([#764](#764)). * Use interactive prompt to select resource to run if not specified ([#762](#762)). * Add documentation link bundle command group description ([#770](#770)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Display an interactive prompt with a list of resources to run if one isn't specified and the command is run interactively.
Tests
Manually confirmed: