Repository navigation
Replace U2M token cache with Store - #6619
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 9db5ca5
Top 6 slowest tests (at least 2 minutes):
|
renaudhartert-db
changed the title
mihaimitrea-db
approved these changes
Sep 11, 2026
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Changes This is a no-op cleanup of CLI OAuth token storage. U2M previously used its own TokenCache interface while CLI auth used storage.Store, requiring adapters between two abstractions with the same role. This PR removes libs/auth/u2m/cache and makes U2M use storage.Store directly. The in-memory implementation and OAuth-specific wrappers now live in libs/auth/storage. Token keys, persisted formats, lookup and refresh behavior, not-found hints, and legacy host-key dual writes are unchanged. ## Why The U2M token cache and storage.Store now serve the same role. Keeping both abstractions requires adapters and duplicates token storage behavior without adding separation of responsibility. ## Tests - Focused auth and storage tests pass. - Repository checks and the full unit suite pass (10,035 tests). - Changed-file Go lint reports no issues. _This PR was written with Codex._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a no-op cleanup of CLI OAuth token storage.
U2M previously used its own TokenCache interface while CLI auth used storage.Store, requiring adapters between two abstractions with the same role. This PR removes libs/auth/u2m/cache and makes U2M use storage.Store directly. The in-memory implementation and OAuth-specific wrappers now live in libs/auth/storage.
Token keys, persisted formats, lookup and refresh behavior, not-found hints, and legacy host-key dual writes are unchanged.
Why
The U2M token cache and storage.Store now serve the same role. Keeping both abstractions requires adapters and duplicates token storage behavior without adding separation of responsibility.
Tests
This PR was written with Codex.