Skip to content

Propagate TF_CLI_CONFIG_FILE env variable#555

Merged
pietern merged 6 commits intodatabricks:mainfrom
kanterov:tf-cli-config-file
Jul 7, 2023
Merged

Propagate TF_CLI_CONFIG_FILE env variable#555
pietern merged 6 commits intodatabricks:mainfrom
kanterov:tf-cli-config-file

Conversation

@kanterov
Copy link
Copy Markdown
Collaborator

@kanterov kanterov commented Jul 6, 2023

Changes

Propagate TF_CLI_CONFIG_FILE env variable.

From Terraform documentation:

The location of the Terraform CLI configuration file can also be specified using the TF_CLI_CONFIG_FILE environment variable

It allows using custom builds of terraform-provider-databricks, using config files like:

provider_installation {
  dev_overrides {
    "databricks/databricks" = "/Users/gleb.kanterov/terraform-provider-databricks"
  }

  direct {}
}

Tests

I added unit tests.

@kanterov kanterov marked this pull request as ready for review July 6, 2023 14:07
@lennartkats-db lennartkats-db requested a review from pietern July 6, 2023 14:13
Copy link
Copy Markdown
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit, rest LGTM.

@kanterov
Copy link
Copy Markdown
Collaborator Author

kanterov commented Jul 7, 2023

@pietern thanks for the review! Will you merge? I don't have a button

@pietern pietern merged commit 1791544 into databricks:main Jul 7, 2023
@kanterov kanterov deleted the tf-cli-config-file branch July 7, 2023 11:20
@pietern pietern mentioned this pull request Jul 7, 2023
pietern added a commit that referenced this pull request Jul 10, 2023
## Changes

CLI:
* Fix secrets put-secret command
([#545](#545)).
* Fixed ignoring required positional parameters when --json flag is
provided ([#535](#535)).
* Update cp help message to not require file scheme
([#554](#554)).

Bundles:
* Fix: bundle destroy fails when bundle.tf.json file is deleted
([#519](#519)).
* Fixed error reporting when included invalid files in include section
([#543](#543)).
* Make top level workspace optional in JSON schema
([#562](#562)).
* Propagate TF_CLI_CONFIG_FILE env variable
([#555](#555)).
* Update Terraform provider schema structs
([#563](#563)).
* Update inline JSON schema documentation
([#557](#557)).

Dependencies:
* Bump Go SDK to v0.12.0
([#540](#540)).
* Bump github.com/hashicorp/terraform-json from 0.17.0 to 0.17.1
([#541](#541)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants