Fixed error reporting when included invalid files in include section#543
Merged
andrewnester merged 5 commits intomainfrom Jul 7, 2023
Merged
Fixed error reporting when included invalid files in include section#543andrewnester merged 5 commits intomainfrom
andrewnester merged 5 commits intomainfrom
Conversation
pietern
reviewed
Jul 4, 2023
pietern
reviewed
Jul 4, 2023
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Please also add a case where there are no matches and the pattern is a glob.
Everything else LGTM!
Contributor
Author
|
@pietern "[a-z].yml" and "?.yml" glob patterns from the test above actually cover it already as they don't match any files |
pietern
approved these changes
Jul 7, 2023
Merged
pietern
added a commit
that referenced
this pull request
Jul 10, 2023
## Changes CLI: * Fix secrets put-secret command ([#545](#545)). * Fixed ignoring required positional parameters when --json flag is provided ([#535](#535)). * Update cp help message to not require file scheme ([#554](#554)). Bundles: * Fix: bundle destroy fails when bundle.tf.json file is deleted ([#519](#519)). * Fixed error reporting when included invalid files in include section ([#543](#543)). * Make top level workspace optional in JSON schema ([#562](#562)). * Propagate TF_CLI_CONFIG_FILE env variable ([#555](#555)). * Update Terraform provider schema structs ([#563](#563)). * Update inline JSON schema documentation ([#557](#557)). Dependencies: * Bump Go SDK to v0.12.0 ([#540](#540)). * Bump github.com/hashicorp/terraform-json from 0.17.0 to 0.17.1 ([#541](#541)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed error reporting when included invalid files in include section
Case 1. When the file to include is invalid, throw an error
Case 2. When the file is loaded but the schema is wrong, indicate which file is failed to load
Tests
With non-existent notexists.yml
With malformed notexists.yml