Remove SkipEngineEnvVar from ProcessOptions#4759
Merged
Conversation
… instead Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
shreyas-goenka
approved these changes
Mar 16, 2026
Collaborator
|
Commit: 5eb7190
18 interesting tests: 9 SKIP, 6 RECOVERED, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: a5ab0f3
68 interesting tests: 33 MISS, 17 RECOVERED, 7 flaky, 4 KNOWN, 4 FAIL, 2 PANIC, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
rauchy
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Changes - Remove `SkipEngineEnvVar` field from `ProcessOptions` in `process.go` - In `migrate.go`, clear `DATABRICKS_BUNDLE_ENGINE` in the context via `env.Set(ctx, engine.EnvVar, "")` before calling `ProcessBundleRet`, achieving the same effect ## Why Simplify env var handling for #4749 ## Test plan Existing tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SkipEngineEnvVarfield fromProcessOptionsinprocess.gomigrate.go, clearDATABRICKS_BUNDLE_ENGINEin the context viaenv.Set(ctx, engine.EnvVar, "")before callingProcessBundleRet, achieving the same effectWhy
Simplify env var handling for #4749
Test plan
Existing tests.
🤖 Generated with Claude Code