Remove unused configRoot parameter from DeploymentBundle.Apply#4673
Merged
Remove unused configRoot parameter from DeploymentBundle.Apply#4673
Conversation
It must not be used, all actions must be performed based on plan, not config. Needed for "bundle deploy --plan" to work reliably. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
pietern
approved these changes
Mar 6, 2026
Collaborator
|
Commit: 2b1cceb
25 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 1 BUG, 1 flaky, 1 RECOVERED
Top 21 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: c8f42ce
39 interesting tests: 16 RECOVERED, 12 FAIL, 7 KNOWN, 2 flaky, 1 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It must not be used, all actions must be performed based on plan, not config. Needed for "bundle deploy --plan" to work reliably (#4134).