Include [DEFAULT] section header when writing ~/.databrickscfg#464
Merged
Include [DEFAULT] section header when writing ~/.databrickscfg#464
Conversation
The ini library omits the default section header and in doing so breaks compatibility with Python's config parser. It raises: ``` Error: MissingSectionHeaderError: File contains no section headers. ``` This commit makes sure the DEFAULT section header is included. If the config file doesn't include a DEFAULT section itself, we include a comment describing its purpose.
pietern
requested review from
PaulCornellDB,
andrewnester,
nfx and
shreyas-goenka
PaulCornellDB
approved these changes
Jun 12, 2023
Contributor
PaulCornellDB
left a comment
PaulCornellDB
left a comment
There was a problem hiding this comment.
LGTM with a few very minor grammatical edits.
Co-authored-by: PaulCornellDB <[email protected]>
Co-authored-by: PaulCornellDB <[email protected]>
nfx
approved these changes
Jun 13, 2023
Merged
pietern
added a commit
that referenced
this pull request
Jun 15, 2023
## Changes CLI: * Add workspace import-dir command ([#456](#456)). * Annotate generated commands with OpenAPI package name ([#466](#466)). * Associate generated commands with command groups ([#475](#475)). * Disable shell completions for generated commands ([#483](#483)). * Include [DEFAULT] section header when writing ~/.databrickscfg ([#464](#464)). * Pass through proxy related environment variables ([#465](#465)). * Restore flags to original values on test completion ([#470](#470)). * Update configure command ([#482](#482)). Dependencies: * Bump SDK to latest ([#473](#473)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The ini library omits the default section header and in doing so breaks compatibility with Python's config parser. It raises:
This commit makes sure the DEFAULT section header is included.
If the config file doesn't include a DEFAULT section itself, we include a comment describing its purpose.
Tests
New tests pass. Manually confirmed the DEFAULT section header is included.