:q :Q erge remote-tracking branch 'origin' into fix-fuse-generate#4324
Closed
shreyas-goenka wants to merge 9 commits intomainfrom
Closed
:q
:Q
erge remote-tracking branch 'origin' into fix-fuse-generate#4324shreyas-goenka wants to merge 9 commits intomainfrom
shreyas-goenka wants to merge 9 commits intomainfrom
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
3 tasks
shreyas-goenka
added a commit
that referenced
this pull request
Mar 13, 2026
…ment (#4627) ## Summary - Use `OverrideChangeDesc` to suppress the `/Workspace` prefix diff on experiment names, matching the Terraform provider's `experimentNameSuppressDiff` behavior - Fix test server `ExperimentUpdate` to strip `/Workspace` prefix, matching cloud behavior - Add acceptance test coverage for both `/Workspace/Users/...` and `/Users/...` path forms - Resolves #4285 #4324 ## Why? The backend always strips the `/Workspace` prefix from experiment names, so remote returns `/Users/...` while the config has `/Workspace/Users/...`. Instead of mutating the config value (stripping the prefix in `ApplyPresets`), we suppress the diff during change detection via `OverrideChangeDesc` — the same approach the Terraform provider uses with its [`experimentNameSuppressDiff`](https://github.com/databricks/terraform-provider-databricks/blob/8945a7b2328659b1fc976d04e32457305860131f/mlflow/resource_mlflow_experiment.go#L13) function. Without this fix you get a persistent drift: ``` "name": { "action": "update", "old": "/Workspace/Users/[email protected]/test-experiment-bundle", "new": "/Workspace/Users/[email protected]/test-experiment-bundle", "remote": "/Users/[email protected]/test-experiment-bundle" }, ``` ## Test plan - [x] Acceptance test `bundle/deployment/bind/experiment` verifies plan shows 0 changes with `/Workspace/Users/...` path - [x] Same test verifies plan shows 0 changes with `/Users/...` path (without `/Workspace` prefix) - [x] `bundle/resources/experiments/basic` acceptance test still passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
rauchy
pushed a commit
that referenced
this pull request
Mar 17, 2026
…ment (#4627) ## Summary - Use `OverrideChangeDesc` to suppress the `/Workspace` prefix diff on experiment names, matching the Terraform provider's `experimentNameSuppressDiff` behavior - Fix test server `ExperimentUpdate` to strip `/Workspace` prefix, matching cloud behavior - Add acceptance test coverage for both `/Workspace/Users/...` and `/Users/...` path forms - Resolves #4285 #4324 ## Why? The backend always strips the `/Workspace` prefix from experiment names, so remote returns `/Users/...` while the config has `/Workspace/Users/...`. Instead of mutating the config value (stripping the prefix in `ApplyPresets`), we suppress the diff during change detection via `OverrideChangeDesc` — the same approach the Terraform provider uses with its [`experimentNameSuppressDiff`](https://github.com/databricks/terraform-provider-databricks/blob/8945a7b2328659b1fc976d04e32457305860131f/mlflow/resource_mlflow_experiment.go#L13) function. Without this fix you get a persistent drift: ``` "name": { "action": "update", "old": "/Workspace/Users/[email protected]/test-experiment-bundle", "new": "/Workspace/Users/[email protected]/test-experiment-bundle", "remote": "/Users/[email protected]/test-experiment-bundle" }, ``` ## Test plan - [x] Acceptance test `bundle/deployment/bind/experiment` verifies plan shows 0 changes with `/Workspace/Users/...` path - [x] Same test verifies plan shows 0 changes with `/Users/...` path (without `/Workspace` prefix) - [x] `bundle/resources/experiments/basic` acceptance test still passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests