Don't pass synthesized TMPDIR if not already set#409
Merged
Conversation
shreyas-goenka
approved these changes
May 26, 2023
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Changes look good to me
andrewnester
approved these changes
May 26, 2023
Merged
pietern
added a commit
that referenced
this pull request
May 26, 2023
## Changes CLI: * Reduce parallellism in locker integration test ([#407](#407)). Bundles: * Don't pass synthesized TMPDIR if not already set ([#409](#409)). * Added support for bundle.Seq, simplified Mutator.Apply interface ([#403](#403)). * Regenerated internal schema structs based on Terraform provider schemas ([#401](#401)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On Unix systems, the default of
/tmpalways works. No need to synthesize a path for it.The custom TMPDIR was causing issues when used from GitHub Actions runners.
Tests
Confirmed manually this fixes the issue on GitHub Actions runners.