Skip to content

Fix #3109: default search location for whl artifacts#3184

Merged
denik merged 4 commits intomainfrom
denik/issue3109
Jul 7, 2025
Merged

Fix #3109: default search location for whl artifacts#3184
denik merged 4 commits intomainfrom
denik/issue3109

Conversation

@denik
Copy link
Copy Markdown
Contributor

@denik denik commented Jul 7, 2025

Changes

When initializing artifacts.*.files.source to default <Path>/dist/*.whl we used to (in version 0.254.0 and earlier) first to initialize path to bundle root then join it with "dist/*.whl". After #2987 we switched to first initializing Files.Source then initializing Path, thus breaking some cases, see #3109

Tests

New acceptance regression test, reproduces #3109 without this PR ebffb67

@denik denik temporarily deployed to test-trigger-is July 7, 2025 08:28 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is July 7, 2025 08:32 — with GitHub Actions Inactive
@denik denik changed the title acc: Add a test case for issue #3109 Fix #3109: default search location for whl artifacts Jul 7, 2025
@denik denik enabled auto-merge July 7, 2025 08:36
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Jul 7, 2025

Run: 16112892839

Env ✅‌pass ❌‌FAIL 💥‌PANIC 🔄‌flaky 🙈‌skip 🤯‌MISS
❌‌ aws linux 291 9 1 375 3
❌‌ aws windows 299 1 5 374
🔄‌ aws-ucws linux 411 1 275
✅‌ aws-ucws windows 413 274
✅‌ azure linux 306 374
✅‌ azure windows 307 373
✅‌ azure-ucws linux 414 272
✅‌ azure-ucws windows 415 271
✅‌ gcp linux 305 376
🔄‌ gcp windows 304 2 375
16 failing tests:
Test Name aws linux aws windows aws-ucws linux gcp windows
TestAccept ❌‌FAIL 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines ❌‌FAIL ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines/DATABRICKS_CLI_DEPLOYMENT=direct-exp ❌‌FAIL ✅‌pass ✅‌pass ✅‌pass
TestAccept/selftest/record_cloud/workspace-file-io ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/selftest/record_cloud/workspace-file-io/DATABRICKS_CLI_DEPLOYMENT=terraform ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestFetchRepositoryInfoAPI_FromRepo ❌‌FAIL ❌‌FAIL ✅‌pass ✅‌pass
TestLock ❌‌FAIL ✅‌pass ✅‌pass 🔄‌flaky
TestReposCreateWithProvider ❌‌FAIL ✅‌pass ✅‌pass 🔄‌flaky
TestReposCreateWithoutProvider ❌‌FAIL ✅‌pass ✅‌pass ✅‌pass
TestReposDeleteByPath ❌‌FAIL 🔄‌flaky ✅‌pass ✅‌pass
TestSyncEnsureRemotePathIsUsableIfRepoDoesntExist 🤯‌MISS ✅‌pass ✅‌pass ✅‌pass
TestSyncEnsureRemotePathIsUsableIfRepoExists 🤯‌MISS 🔄‌flaky ✅‌pass ✅‌pass
TestSyncEnsureRemotePathIsUsableInWorkspace 🤯‌MISS ✅‌pass ✅‌pass ✅‌pass
TestSyncIncrementalSyncFileToPythonNotebook ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass
TestSyncIncrementalSyncPythonNotebookDelete 💥‌PANIC ✅‌pass ✅‌pass ✅‌pass
TestSyncNestedSpacePlusAndHashAreEscapedSync ❌‌FAIL ✅‌pass ✅‌pass ✅‌pass

@denik denik had a problem deploying to test-trigger-is July 7, 2025 08:57 — with GitHub Actions Failure
@denik denik requested a review from andrewnester July 7, 2025 08:57
@denik denik disabled auto-merge July 7, 2025 09:11
@denik denik temporarily deployed to test-trigger-is July 7, 2025 09:14 — with GitHub Actions Inactive
@denik denik merged commit 360a6a7 into main Jul 7, 2025
12 of 14 checks passed
@denik denik deleted the denik/issue3109 branch July 7, 2025 09:21
denik added a commit that referenced this pull request Jul 7, 2025
deco-sdk-tagging bot added a commit that referenced this pull request Jul 10, 2025
## Release v0.259.0

### Notable Changes
* Add support for arbitrary scripts in DABs. Users can now define scripts in their bundle configuration. These scripts automatically inherit the bundle's credentials for authentication. They can be invoked with the `bundle run` command. ([#2813](#2813))
* Error when the absolute path to `databricks.yml` contains a glob character. These are: `*`, `?`, `[`, `]` and `^`. If the path to the `databricks.yml` file on your local filesystem contains one of these characters, that could lead to incorrect computation of glob patterns for the `includes` block and might cause resources to be deleted. After this patch users will not be at risk for unexpected deletions due to this issue. ([#3096](#3096))
* Diagnostics messages are no longer buffered to be printed at the end of command, flushed after every mutator ([#3175](#3175))
* Diagnostics are now always rendered with forward slashes in file paths, even on Windows ([#3175](#3175))
* "bundle summary" now prints diagnostics to stderr instead of stdout in text output mode ([#3175](#3175))
* "bundle summary" no longer prints recommendations, it will only prints warnings and errors ([#3175](#3175))

### Bundles
* Fix default search location for whl artifacts ([#3184](#3184)). This was a regression introduced in 0.255.0.
* The job tasks are now sorted by task key in "bundle validate/summary" output ([#3212](#3212))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants