Simplify & fix default configuration for whl artifacts#2987
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
pietern
approved these changes
Jun 4, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Nice find and simplification.
Co-authored-by: Pieter Noordhuis <[email protected]>
denik
added a commit
that referenced
this pull request
Jul 7, 2025
## Changes When initializing `artifacts.*.files.source` to default `<Path>/dist/*.whl` we used to (in version 0.254.0 and earlier) first to initialize path to bundle root then join it with "dist/*.whl". After #2987 we switched to first initializing Files.Source then initializing Path, thus breaking some cases, see #3109 ## Tests New acceptance regression test, reproduces #3109 without this PR ebffb67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests
Existing tests.