Merged
Conversation
Contributor
|
With an alternative in the works, shall we skip this? |
Contributor
Author
|
@pietern I have not yet looked into Traceparent. I'll followup on this and close it once I verify it would work. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Author
|
For some social proof, the az CLI also does something similar, but to correlate the multiple telemetry logs recorded in a single CLI invocation: |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 31, 2024
shreyas-goenka
changed the title
cmd-exec-id to user agent to correlate API calls from the same command execution
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 31, 2024
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/11613171225 |
pietern
changed the title
cmd-exec-id to user agent to correlate API calls from the same command executioncmd-exec-id to user agent
pietern
reviewed
Nov 1, 2024
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
The change LGTM. Please update the PR summary. If you want to keep the discussion about traceparent around, it should move to its own section. Now it reads as if this PR has any bearing on traceparent, but it doesn't.
pietern
approved these changes
Nov 1, 2024
andrewnester
added a commit
that referenced
this pull request
Nov 6, 2024
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
CLI: * Clean host URL in the `auth login` command ([#1879](#1879)). Bundles: * Fix bundle run when run interactively ([#1880](#1880)). * Fix relative path resolution for dashboards on Windows ([#1881](#1881)). Internal: * Address goreleaser deprecation warning ([#1872](#1872)). * Update actions/github-script to v7 ([#1873](#1873)). * Use Go 1.23 ([#1871](#1871)). * [Internal] Always write message for manual integration test trigger ([#1874](#1874)). * Add `cmd-exec-id` to user agent ([#1808](#1808)). * Added E2E test to run Python wheels on interactive cluster created in bundle ([#1864](#1864)). Dependency updates: * Bump github.com/hashicorp/terraform-json from 0.22.1 to 0.23.0 ([#1877](#1877)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the
cmd-exec-idfield to the user agent. This allows us to correlate multiple HTTP requests made from the CLI.Why Not Use HTTP traceparent?
We considered using the traceparent header in HTTP as an alternative, but it's not a good fit for our use case. Here's why:
For more details about how traceparent itself works and how it's used in the Go SDK, see databricks/databricks-sdk-go#914.
Tests
Unit test