Add regression tests for CLI error output#1566
Merged
pietern merged 5 commits intodatabricks:mainfrom Jul 10, 2024
Merged
Conversation
pietern
reviewed
Jul 4, 2024
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Could you also modify cobraTestRunner in internal/helpers.go to use the same?
main.go
Outdated
Comment on lines
+13
to
+15
| code := root.Execute(ctx, cmd.New(ctx)) | ||
|
|
||
| os.Exit(code) |
Contributor
There was a problem hiding this comment.
Suggested change
| code := root.Execute(ctx, cmd.New(ctx)) | |
| os.Exit(code) | |
| code := root.Execute(ctx, cmd.New(ctx)) | |
| os.Exit(code) |
cmd/root/root_test.go
Outdated
Comment on lines
+1
to
+2
| package root_test // using 'root' will create circular import | ||
| import ( |
Contributor
There was a problem hiding this comment.
The circular import thing is implied. We use the same pattern in other places.
Suggested change
| package root_test // using 'root' will create circular import | |
| import ( | |
| package root_test | |
| import ( |
Contributor
lennartkats-db
left a comment
lennartkats-db
left a comment
There was a problem hiding this comment.
PTAL at Pieter's comments, and please make the PR title a bit more descriptive for changelog purposes, otherwise LGTM
kanterov
changed the title
Collaborator
Author
|
@pietern I didn't know |
pietern
reviewed
Jul 4, 2024
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
LGTM, thanks
I'm triggering an integration test run to confirm they pass with the modified helper.
Collaborator
Author
|
@pietern is this good to merge? |
Contributor
|
Yes, good to go! |
pietern
approved these changes
Jul 10, 2024
andrewnester
added a commit
that referenced
this pull request
Jul 10, 2024
Bundles: * Override complex variables with target overrides instead of merging ([#1567](#1567)). * Rewrite local path for libraries in foreach tasks ([#1569](#1569)). * Change SetVariables mutator to mutate dynamic configuration instead ([#1573](#1573)). * Return early in bundle destroy if no deployment exists ([#1581](#1581)). * Let notebook detection code use underlying metadata if available ([#1574](#1574)). * Remove schema override for variable default value ([#1536](#1536)). * Print diagnostics in 'bundle deploy' ([#1579](#1579)). Internal: * Update actions/upload-artifact to v4 ([#1559](#1559)). * Use Go 1.22 to build and test ([#1562](#1562)). * Move bespoke status call to main workspace files filer ([#1570](#1570)). * Add new template ([#1578](#1578)). * Add regression tests for CLI error output ([#1566](#1566)). Dependency updates: * Bump golang.org/x/mod from 0.18.0 to 0.19.0 ([#1576](#1576)). * Bump golang.org/x/term from 0.21.0 to 0.22.0 ([#1577](#1577)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Bundles: * Override complex variables with target overrides instead of merging ([#1567](#1567)). * Rewrite local path for libraries in foreach tasks ([#1569](#1569)). * Change SetVariables mutator to mutate dynamic configuration instead ([#1573](#1573)). * Return early in bundle destroy if no deployment exists ([#1581](#1581)). * Let notebook detection code use underlying metadata if available ([#1574](#1574)). * Remove schema override for variable default value ([#1536](#1536)). * Print diagnostics in 'bundle deploy' ([#1579](#1579)). Internal: * Update actions/upload-artifact to v4 ([#1559](#1559)). * Use Go 1.22 to build and test ([#1562](#1562)). * Move bespoke status call to main workspace files filer ([#1570](#1570)). * Add new template ([#1578](#1578)). * Add regression tests for CLI error output ([#1566](#1566)). Dependency updates: * Bump golang.org/x/mod from 0.18.0 to 0.19.0 ([#1576](#1576)). * Bump golang.org/x/term from 0.21.0 to 0.22.0 ([#1577](#1577)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add regression tests for #1563
We test 2 code paths:
We should also consider adding black-box tests that will run the CLI binary as a black box and inspect its output to stderr/stdout.
Tests
Unit tests