Add forbidigo rules for terminal detection and fix violations (#4302)

pietern · claude · web-flow · commit 94ab80da575f · 2026-01-19T02:10:40.000-08:00
## Changes Configure forbidigo to prevent direct use of term.IsTerminal and isatty functions outside libs/cmdio. Depends on #4298 and #4301. ## Why Use cmdio.IsPromptSupported() instead for consistent capability detection. --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -20,6 +20,15 @@ linters:
     - copyloopvar
     - forbidigo
   settings:
+    forbidigo:
+      forbid:
+        - pattern: 'term\.IsTerminal'
+          msg: Use cmdio.IsPromptSupported(ctx) to check for a TTY.
+        - pattern: 'isatty\.IsTerminal'
+          msg: Use cmdio.IsPromptSupported(ctx) to check for a TTY.
+        - pattern: 'isatty\.IsCygwinTerminal'
+          msg: Use cmdio.IsPromptSupported(ctx) to check for a TTY.
+      analyze-types: true
     copyloopvar:
       check-alias: true
     errcheck:
@@ -96,9 +105,6 @@ linters:
       - path: bundle/direct/dresources/.*_test.go
         linters:
           - exhaustruct
-      - path-except: ^cmd
-        linters:
-          - forbidigo
 issues:
   max-issues-per-linter: 1000
   max-same-issues: 1000
diff --git a/acceptance/pipelines/destroy/auto-approve/output.txt b/acceptance/pipelines/destroy/auto-approve/output.txt
@@ -8,7 +8,7 @@ Deployment complete!
 View your pipeline my_pipeline here: [DATABRICKS_URL]/pipelines/[UUID]?o=[NUMID]
 
 >>> errcode [PIPELINES] destroy
-Error: please specify --auto-approve to skip interactive confirmation checks for non tty consoles
+Error: please specify --auto-approve since terminal does not support interactive prompts
 
 Exit code: 1
 
diff --git a/cmd/bundle/destroy.go b/cmd/bundle/destroy.go
@@ -4,15 +4,14 @@ package bundle
 
 import (
 	"errors"
-	"os"
 
 	"github.com/databricks/cli/bundle"
 	"github.com/databricks/cli/bundle/phases"
 	"github.com/databricks/cli/cmd/bundle/utils"
 	"github.com/databricks/cli/cmd/root"
+	"github.com/databricks/cli/libs/cmdio"
 	"github.com/databricks/cli/libs/logdiag"
 	"github.com/spf13/cobra"
-	"golang.org/x/term"
 )
 
 func newDestroyCommand() *cobra.Command {
@@ -47,10 +46,9 @@ Typical use cases:
 }
 
 func CommandBundleDestroy(cmd *cobra.Command, args []string, autoApprove, forceDestroy bool) error {
-	// we require auto-approve for non tty terminals since interactive consent
-	// is not possible
-	if !term.IsTerminal(int(os.Stderr.Fd())) && !autoApprove {
-		return errors.New("please specify --auto-approve to skip interactive confirmation checks for non tty consoles")
+	// We require auto-approve for non-interactive terminals since prompts are not possible.
+	if !cmdio.IsPromptSupported(cmd.Context()) && !autoApprove {
+		return errors.New("please specify --auto-approve since terminal does not support interactive prompts")
 	}
 
 	opts := utils.ProcessOptions{
diff --git a/go.mod b/go.mod
@@ -34,7 +34,7 @@ require (
 	golang.org/x/oauth2 v0.34.0
 	golang.org/x/sync v0.19.0
 	golang.org/x/sys v0.40.0
-	golang.org/x/term v0.39.0
+	golang.org/x/term v0.39.0 // indirect
 	golang.org/x/text v0.33.0
 	gopkg.in/ini.v1 v1.67.0 // Apache 2.0
 	gopkg.in/yaml.v3 v3.0.1
diff --git a/libs/cmdio/tty.go b/libs/cmdio/tty.go
@@ -20,7 +20,7 @@ func isTTY(v any) bool {
 		return false
 	}
 	fd := f.Fd()
-	return isatty.IsTerminal(fd) || isatty.IsCygwinTerminal(fd)
+	return isatty.IsTerminal(fd) || isatty.IsCygwinTerminal(fd) //nolint:forbidigo
 }
 
 // fakeTTY wraps an io.Writer and makes IsTTY return true for it.

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ func isTTY(v any) bool {`
`20`	`20`	`return false`
`21`	`21`	`}`
`22`	`22`	`fd := f.Fd()`
`23`		`- return isatty.IsTerminal(fd) \|\| isatty.IsCygwinTerminal(fd)`
	`23`	`+ return isatty.IsTerminal(fd) \|\| isatty.IsCygwinTerminal(fd) //nolint:forbidigo`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`// fakeTTY wraps an io.Writer and makes IsTTY return true for it.`